This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
change side bar position for anomly detection plugin #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,8 +40,13 @@ export class AnomalyDetectionKibanaPlugin | |||
| core.application.register({ | |||
| id: 'opendistro-anomaly-detection-kibana', | |||
| title: 'Anomaly Detection', | |||
| category: DEFAULT_APP_CATEGORIES.kibana, | |||
There was a problem hiding this comment.
thanks for the change, can you also remove the unused import DEFAULT_APP_CATEGORIES at line 22 after the only usage is removed?
There was a problem hiding this comment.
sure. Thanks for reminding.
yizheliu-amazon
approved these changes
Nov 25, 2020
seraphjiang
approved these changes
Nov 25, 2020
ohltyler
added
the
enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Change position of Anomaly detection plugin in side bar.
The order is designed by UX designer and in step of 1000(https://github.com/elastic/kibana/blob/master/docs/development/core/public/kibana-plugin-core-public.appcategory.md).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.