Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Improve batch action modal loading state #216

Merged

Conversation

ohltyler
Copy link
Contributor

@ohltyler ohltyler commented Jun 10, 2020

Issue #, if available: #212

Description of changes:

This PR improves the handling of different cases while the batch action detector modals are in loading state.

Specifically:

  1. Removes the Cancel button when loading
  2. Adds functionality to the x to close the modal when loading
  3. Adds a function parameter to the modals to differ between when a user is confirming the action (putting the modal in loading state) versus just closing the modal.

Screenshot of the delete batch action modal (before):

Screen Shot 2020-06-09 at 5 00 25 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ohltyler ohltyler linked an issue Jun 10, 2020 that may be closed by this pull request
@ohltyler ohltyler merged commit dd2bb5f into opendistro-for-elasticsearch:master Jun 11, 2020
@ohltyler ohltyler added the enhancement Enhance current feature for better performance, user experience, etc label Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhance current feature for better performance, user experience, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle closing of modal while loading better
3 participants