Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Handle closing of modal while loading better #212

Closed
ohltyler opened this issue Jun 10, 2020 · 0 comments · Fixed by #216
Closed

Handle closing of modal while loading better #212

ohltyler opened this issue Jun 10, 2020 · 0 comments · Fixed by #216
Assignees
Labels
enhancement Enhance current feature for better performance, user experience, etc

Comments

@ohltyler
Copy link
Contributor

ohltyler commented Jun 10, 2020

Currently, if a user performs a batch action, the modals will stay open and display a loading state until all detectors are updated. It then closes and an updated detector list is shown:

Screen Shot 2020-06-09 at 5 00 25 PM

During this loading state, a user may still want to close out the modal. Right now, the Cancel button and the x to close the modal don't do anything if the user was to click on them when the modal is in the loading state.

Fix this by:

  1. Removing the Cancel button altogether if the modal is in a loading state
  2. Change functionality of the x to successfully close the modal and display the detector list loading state.
@ohltyler ohltyler self-assigned this Jun 10, 2020
@ohltyler ohltyler added the enhancement Enhance current feature for better performance, user experience, etc label Jun 10, 2020
@ohltyler ohltyler linked a pull request Jun 10, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhance current feature for better performance, user experience, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant