Fix integ tests when security is not installed

alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/AlertingRestTestCase.kt

@@ -635,8 +635,8 @@ abstract class AlertingRestTestCase : ODFERestTestCase() {
 
     fun getHeader(): BasicHeader {
         return when (isHttps()) {
-            true -> BasicHeader("dummy", ESRestTestCase.randomAlphaOfLength(20))
-            false -> BasicHeader(ConfigConstants.AUTHORIZATION, ESRestTestCase.randomAlphaOfLength(20))
+            false -> BasicHeader("dummy", ESRestTestCase.randomAlphaOfLength(20))
+            true -> BasicHeader(ConfigConstants.AUTHORIZATION, ESRestTestCase.randomAlphaOfLength(20))
         }
     }
 

alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/resthandler/SecureDestinationRestApiIT.kt

@@ -80,8 +80,8 @@ class SecureDestinationRestApiIT : AlertingRestTestCase() {
         val adminResponse = getDestinations(client(), inputMap, getHeader())
         val expected = when (isHttps()) {
             true -> 1   // when test is run with security - get the correct filtered results.
-            false -> 0  // when test is run without security and filterby is enabled - fails to
-                        // resolve user and filters by empty list, to get zero results.
+            false -> 1  // when test is run without security and filterby is enabled - filtering
+                        // does not work without security, so filtering is ignored and gets a result
         }
         assertEquals(expected, adminResponse.size)
 

alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/resthandler/SecureMonitorRestApiIT.kt

@@ -75,8 +75,8 @@ class SecureMonitorRestApiIT : AlertingRestTestCase() {
         val adminDocsFound = adminHits["total"]?.get("value")
         val expected = when (isHttps()) {
             true -> 1   // when test is run with security - get the correct filtered results.
-            false -> 0  // when test is run without security and filterby is enabled - fails to
-            // resolve user and filters by empty list, to get zero results.
+            false -> 1  // when test is run without security and filterby is enabled - filtering
+                        // does not work without security, so filtering is ignored and gets a result
         }
         assertEquals("Monitor not found during search", expected, adminDocsFound)
 
@@ -131,8 +131,8 @@ class SecureMonitorRestApiIT : AlertingRestTestCase() {
         val adminResponseMap = getAlerts(client(), inputMap, getHeader()).asMap()
         val expected = when (isHttps()) {
             true -> 4   // when test is run with security - get the correct filtered results.
-            false -> 0  // when test is run without security and filterby is enabled - fails to
-            // resolve user and filters by empty list, to get zero results.
+            false -> 4  // when test is run without security and filterby is enabled - filtering
+                        // does not work without security, so filtering is ignored and gets a result
         }
         assertEquals(expected, adminResponseMap["totalAlerts"])
 

core/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/elasticapi/ElasticExtensions.kt

@@ -145,9 +145,9 @@ fun XContentBuilder.optionalUserField(name: String, user: User?): XContentBuilde
 }
 
 fun addFilter(user: User, searchSourceBuilder: SearchSourceBuilder, fieldName: String) {
-    val filterBckendRoles = QueryBuilders.termsQuery(fieldName, user.backendRoles)
+    val filterBackendRoles = QueryBuilders.termsQuery(fieldName, user.backendRoles)
     val queryBuilder = searchSourceBuilder.query() as BoolQueryBuilder
-    searchSourceBuilder.query(queryBuilder.filter(filterBckendRoles))
+    searchSourceBuilder.query(queryBuilder.filter(filterBackendRoles))
 }
 
 /**