This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix integ tests when security is not installed #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lezzago
commented
Oct 22, 2020
Comment on lines
+83
to
+84
| false -> 1 // when test is run without security and filterby is enabled - filtering | ||
| // does not work without security, so filtering is ignored and gets a result |
There was a problem hiding this comment.
Even though the value is the same, I want to have it commented/formatted this way to explain whats going on.
lezzago
commented
Oct 22, 2020
Comment on lines
+78
to
+79
| false -> 1 // when test is run without security and filterby is enabled - filtering | ||
| // does not work without security, so filtering is ignored and gets a result |
There was a problem hiding this comment.
Even though the value is the same, I want to have it commented/formatted this way to explain whats going on.
Comment on lines
+134
to
+135
| false -> 4 // when test is run without security and filterby is enabled - filtering | ||
| // does not work without security, so filtering is ignored and gets a result |
There was a problem hiding this comment.
Even though the value is the same, I want to have it commented/formatted this way to explain whats going on.
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
============================================
- Coverage 80.26% 79.46% -0.80%
+ Complexity 197 196 -1
============================================
Files 150 150
Lines 5132 5132
Branches 661 661
============================================
- Hits 4119 4078 -41
- Misses 652 696 +44
+ Partials 361 358 -3
Continue to review full report at Codecov.
|
skkosuri-amzn
approved these changes
Oct 22, 2020
|
thanks @lezzago for fixing this. 👍 |
ftianli-amzn
approved these changes
Oct 22, 2020
tlfeng
pushed a commit
that referenced
this pull request
Feb 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix integration tests for ODFE distribution if security is not installed
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.