-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduces OSSM plugin for KfDef #515
Commits on Sep 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a0c3710 - Browse repository at this point
Copy the full SHA a0c3710View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09f889f - Browse repository at this point
Copy the full SHA 09f889fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d44088 - Browse repository at this point
Copy the full SHA 9d44088View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1b784d - Browse repository at this point
Copy the full SHA e1b784dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0781cbf - Browse repository at this point
Copy the full SHA 0781cbfView commit details -
chore: migrate pre-existing data science projects (#1)
* add data science migration to init Co-authored-by: Bartosz Majsak <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1b7c664 - Browse repository at this point
Copy the full SHA 1b7c664View commit details -
feat(test): sets up testing for ossm plugin (#3)
* chore: removes unused test setup * feat(test): sets up testing for ossm plugin * feat(make): adds test-ossm target
Configuration menu - View commit details
-
Copy full SHA for f518efb - Browse repository at this point
Copy the full SHA f518efbView commit details -
feat: handles cleanup by using owner ref and cleanup hook (#4)
* feat: introduces OssmResourceTracker resource It is a cluster-scoped resource for tracking objects created by Ossm plugin. Primarily used as owner reference for resources created across namespaces so that they can be garbage collected by Kubernetes when they are not needed anymore. * feat: uses OssmResourceTracker to cleanup owned resources - adds cleanup hook for Delete phase of KfDef operator - moves k8s_utils code to ossm package to keep it in one place for future extraction of the logic * chore: renames plugin to OssmInstaller * chore: moves cleanup logic to single file * feat: handles token volume removal in SMCP * chore: adds plugin name as extra key-value to logger * feat: removes extAuthzProvider on deletion * chore: minor naming fixes
Configuration menu - View commit details
-
Copy full SHA for d2ae6bf - Browse repository at this point
Copy the full SHA d2ae6bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b24dbe - Browse repository at this point
Copy the full SHA 2b24dbeView commit details -
feat: embed templates into operator plugin (#5)
embed templates to OSSM plugin Co-authored-by: Bartosz Majsak <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d86f75e - Browse repository at this point
Copy the full SHA d86f75eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a95952e - Browse repository at this point
Copy the full SHA a95952eView commit details -
fix(test): adds missing commas when constructing assertions
they might have been removed in some merge (?)
Configuration menu - View commit details
-
Copy full SHA for 93ce890 - Browse repository at this point
Copy the full SHA 93ce890View commit details -
Configuration menu - View commit details
-
Copy full SHA for caf1ace - Browse repository at this point
Copy the full SHA caf1aceView commit details -
feat: check pre-requisites on OSSM plugin init (#7)
* add prereq checks to init, add tests --------- Co-authored-by: Bartosz Majsak <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 79f5f54 - Browse repository at this point
Copy the full SHA 79f5f54View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbecd77 - Browse repository at this point
Copy the full SHA dbecd77View commit details -
feat: introduces Features DSL (#8)
- easy builder to define what particular feature consists of - enables the use of existing YAML manifests - allows the definition of additional resources programmatically with a simple func registration - cleanup functions are now part of each feature and are called one after the other - each feature has its own resource tracker object - ability to test smaller parts of the whole thing by using `Feature`s in integration tests
Configuration menu - View commit details
-
Copy full SHA for 3043502 - Browse repository at this point
Copy the full SHA 3043502View commit details -
feat: introduces conditional control plane installation (#10)
* chore: extracts smcp GVR to a var and reuse it in smcp-related funcs * fix: returns err on oauth creation failure instead of nil by mistake * feat: adds ability to enable feature based on predicates in certain cases this information can only be determined at runtime, for example based on user-defined values of the plugin spec. * feat: introduces control plane installation coupled with wait condition * fix: makes feature enabled by default * chore: reworks smcp creation It relies on owner reference so can be cleaned up as other resources * fix: applies cleanups only if feature is enabled Additionally moves OssmResourceTracker creation to .Apply func * feat: reworks plugin integration to use Apply and Delete funcs of KfApp This way we can cleanup the resources in case deploying service mesh manifests because creating those in Generate phase leaves them hanging due to failing Delete hook * fix(reconcile): corrects KfDef status in case of any error Additionally propagates the error through reconcile to keep trying, as it was ignored. * fix: reworks SMCP component readiness check * chore: improves KfApp func docs * chore: reworks logging in verifiers * chore: simplifies CRD existence check * chore: adds tests for feature enablement * fix: sets interval for SMCP polling to 5s * fix: handles types which are derived for built-in ones for example `type InstallationMode string` was previously failing when converting the default value defined in a custom tag. Now there's a check performed and if value can be convereted to a given type it will. In all other cases it will return an error. * fix: sets default control plane installation mode rely on existing installation Proposed installation modes are: - minimal - pre-installed
Configuration menu - View commit details
-
Copy full SHA for e3cd297 - Browse repository at this point
Copy the full SHA e3cd297View commit details -
feat: allows to define token audience
Without this setting certain environments are not working, as service account issuer might be set to different endpoint than kubernetes.default.svc
Configuration menu - View commit details
-
Copy full SHA for 1f84738 - Browse repository at this point
Copy the full SHA 1f84738View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80b9da6 - Browse repository at this point
Copy the full SHA 80b9da6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d741133 - Browse repository at this point
Copy the full SHA d741133View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b72020 - Browse repository at this point
Copy the full SHA 2b72020View commit details -
Configuration menu - View commit details
-
Copy full SHA for d763462 - Browse repository at this point
Copy the full SHA d763462View commit details -
Configuration menu - View commit details
-
Copy full SHA for 468a52f - Browse repository at this point
Copy the full SHA 468a52fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 22e5653 - Browse repository at this point
Copy the full SHA 22e5653View commit details -
feat: splits authz and mesh dashboard config into two features
added logic to wait for the pods to be ready, otherwise patching IOR settings to disabled might not get updated when istio resources are created leading to duplicated route creation
Configuration menu - View commit details
-
Copy full SHA for 1d45f75 - Browse repository at this point
Copy the full SHA 1d45f75View commit details -
chore: waits for control plane to be ready
and unifies logging by adding feature.Name to most of the logs
Configuration menu - View commit details
-
Copy full SHA for 788cc3f - Browse repository at this point
Copy the full SHA 788cc3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 85ae14e - Browse repository at this point
Copy the full SHA 85ae14eView commit details -
chore: removes unnecessary changes
- autoformatting - align with latest master changes
Configuration menu - View commit details
-
Copy full SHA for 1da1b38 - Browse repository at this point
Copy the full SHA 1da1b38View commit details -
Co-authored-by: Bartosz Majsak <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0f4b6bd - Browse repository at this point
Copy the full SHA 0f4b6bdView commit details -
chore: temporarily removes @camgarrison from OWNERS
reason: he is afk for next 2 weeks and will not be able to accept invite to the org, which potentially can make prow check unhappy
Configuration menu - View commit details
-
Copy full SHA for 3489840 - Browse repository at this point
Copy the full SHA 3489840View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c0f754 - Browse repository at this point
Copy the full SHA 0c0f754View commit details
Commits on Sep 7, 2023
-
fix(dashboard): fetches config for modifaction from a ns instead of a…
… cluster without this fix we could fetch OdhDashboardConfig from different ns and try to perform an update on selected app ns, which leads to error and blocks operator from performing entire OSSM setup. Oh well...
Configuration menu - View commit details
-
Copy full SHA for 720e69b - Browse repository at this point
Copy the full SHA 720e69bView commit details -
fix(routing): makes host prefixed with namespace name
otherwise we create route for ns.domain but expects hosts to be opendatahub.domain which obviously does not work. Doh!
Configuration menu - View commit details
-
Copy full SHA for eecc744 - Browse repository at this point
Copy the full SHA eecc744View commit details -
feat: exposes kubeflow env vars in a custom file
Creates ossm.env in each overlays/service-mesh of defined apps so that it can be used e.g. to overwrite configmap values
Configuration menu - View commit details
-
Copy full SHA for 76455ce - Browse repository at this point
Copy the full SHA 76455ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56bd16a - Browse repository at this point
Copy the full SHA 56bd16aView commit details
Commits on Sep 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6cf1a73 - Browse repository at this point
Copy the full SHA 6cf1a73View commit details
Commits on Sep 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3c1b35d - Browse repository at this point
Copy the full SHA 3c1b35dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e061a4 - Browse repository at this point
Copy the full SHA 5e061a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e409f17 - Browse repository at this point
Copy the full SHA e409f17View commit details
Commits on Sep 19, 2023
-
chore: adds Cameron back to OWNERS
Co-authored-by: Cameron Garrison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5fad574 - Browse repository at this point
Copy the full SHA 5fad574View commit details -
chore: adds Cameron back to OWNERS
Co-authored-by: Cameron Garrison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 35460f5 - Browse repository at this point
Copy the full SHA 35460f5View commit details