Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disables autoinject #9

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

cam-garrison
Copy link

Simple change, most time was spent testing. Tested by ensure basic dashboard functionality still works, and that created notebooks are still injected with istio-proxy. Please let me know if you can think of other scenarios to test.

@bartoszmajsak
Copy link

@cam-garrison There are a few other things that come to mind:

  1. What about datascience projects created in the dedicated namespace?
  2. How does it work now on the odh-project-controller side? Do we need to change something there?

@cam-garrison
Copy link
Author

Thanks for the suggestions:

  1. What do you mean dsp created in dedicated namespace? Do you mean notebooks spawned in data science project namespaces? I have tested this and this works.
  2. Will TAL at this change and see if any changes are necessary.

@cam-garrison
Copy link
Author

Looked thru all pieces of project controller as of right now and see no changes needed - no new namespace annotations or labels are needed since the change this introduces is just new pods that require injection now require the istio.io/inject label/anno.

@bartoszmajsak bartoszmajsak changed the title fix: set SMCP autoinject to false fix: disables autoinject Sep 5, 2023
@bartoszmajsak bartoszmajsak merged commit ff71a25 into kf_ossm_plugin Sep 5, 2023
@bartoszmajsak bartoszmajsak deleted the remove-auto-inj branch September 5, 2023 18:06
bartoszmajsak added a commit that referenced this pull request Sep 6, 2023
Co-authored-by: Bartosz Majsak <[email protected]>
bartoszmajsak added a commit that referenced this pull request Sep 6, 2023
Co-authored-by: Bartosz Majsak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants