-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ODH Dashboard CRDs to owned CRDs in 1.4.1 CSV #188
Conversation
a3caa99
to
9471e85
Compare
8d1940a
to
bbb1cba
Compare
...m-catalog/opendatahub/1.4.1/manifests/opendatahub-operator.v1.4.1.clusterserviceversion.yaml
Show resolved
Hide resolved
...m-catalog/opendatahub/1.4.1/manifests/opendatahub-operator.v1.4.1.clusterserviceversion.yaml
Show resolved
Hide resolved
bbb1cba
to
1ec7ab0
Compare
Signed-off-by: Landon LaSmith <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1ec7ab0
to
187b2f4
Compare
New changes are detected. LGTM label has been removed. |
/retest |
/lgtm |
@LaVLaS: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…-io#188) - it is not in use and was previously imported from modelmesh Signed-off-by: Wen Zhou <[email protected]>
Required for successful deployment of opendatahub-io/odh-manifests#693
Closes #185
Signed-off-by: Landon LaSmith [email protected]
Description
Creates an odh v1.4.1 operator bundle and adds the ODH Dashboard CRDs to the list of owned CRDs for ODH
How Has This Been Tested?
Create a catalogsource with this bundle and installed the operator
Merge criteria:
ODH 1.4.1 operator can be deployed successfully from this bundle
New CRDs are included in the OperatorHub tile for ODH
User with appropriate permission can create customresources based on these tiles
The commits are squashed in a cohesive manner and have meaningful messages.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work