Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ODH Dashboard CRDs to owned CRDs in 1.4.1 CSV #188

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

LaVLaS
Copy link
Contributor

@LaVLaS LaVLaS commented Nov 3, 2022

Required for successful deployment of opendatahub-io/odh-manifests#693
Closes #185

Signed-off-by: Landon LaSmith [email protected]

Description

Creates an odh v1.4.1 operator bundle and adds the ODH Dashboard CRDs to the list of owned CRDs for ODH

How Has This Been Tested?

Create a catalogsource with this bundle and installed the operator

Merge criteria:

  • ODH 1.4.1 operator can be deployed successfully from this bundle

  • New CRDs are included in the OperatorHub tile for ODH

  • User with appropriate permission can create customresources based on these tiles

  • The commits are squashed in a cohesive manner and have meaningful messages.

  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).

  • The developer has manually tested the changes and verified that the changes work

@LaVLaS LaVLaS changed the title WIP: Add ODH Dashboard CRDs to owned CRDs in 1.4.1 CSV Add ODH Dashboard CRDs to owned CRDs in 1.4.1 CSV Nov 30, 2022
@LaVLaS LaVLaS force-pushed the add-dashboard-crds branch 2 times, most recently from 8d1940a to bbb1cba Compare November 30, 2022 14:03
@LaVLaS LaVLaS requested review from VaishnaviHire and removed request for samuelvl December 5, 2022 17:22
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 6, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2022

New changes are detected. LGTM label has been removed.

@LaVLaS
Copy link
Contributor Author

LaVLaS commented Dec 6, 2022

/retest

@LaVLaS
Copy link
Contributor Author

LaVLaS commented Dec 6, 2022

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2022

@LaVLaS: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LaVLaS LaVLaS merged commit 5f3378a into opendatahub-io:master Dec 6, 2022
@LaVLaS LaVLaS deleted the add-dashboard-crds branch December 6, 2022 22:31
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Feb 9, 2024
…-io#188)

- it is not in use and was previously imported from modelmesh

Signed-off-by: Wen Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add *.opendatahub.io CRDs as Owned to the operator CSV
2 participants