-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init: import code from rhods-operator 2.15 + new commits for 2.16 from incubation #1309
init: import code from rhods-operator 2.15 + new commits for 2.16 from incubation #1309
Conversation
Signed-off-by: Wen Zhou <[email protected]>
Signed-off-by: Wen Zhou <[email protected]>
Signed-off-by: Wen Zhou <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rhoai #1309 +/- ##
========================================
Coverage ? 19.04%
========================================
Files ? 30
Lines ? 3308
Branches ? 0
========================================
Hits ? 630
Misses ? 2609
Partials ? 69 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Wen Zhou <[email protected]>
Signed-off-by: Wen Zhou <[email protected]>
@zdtsw I think we also need to add rhoai to openshift-ci config to run |
yes, i am prepare for openshift-ci on this branch |
Signed-off-by: Wen Zhou <[email protected]>
/test all |
f9a7ffe
to
41a46c8
Compare
/test ci-index |
Signed-off-by: Wen Zhou <[email protected]>
… in reconcile (opendatahub-io#1312) (cherry picked from commit bde4b4e)
…o#1281) * update: remove dsp with v1(tekton)backend related code - images - tekton rbac - descriptions Signed-off-by: Wen Zhou <[email protected]> Co-authored-by: Humair Khan <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> Co-authored-by: Humair Khan <[email protected]> (cherry picked from commit 133b710)
Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit c0e0709)
Signed-off-by: Wen Zhou <[email protected]> Co-authored-by: ajaypratap003 <[email protected]> (cherry picked from commit 511977e)
* chore: Tidy run-nowebhook recipe The suggestion to tidy up the run-nowebhook recipe comes from this conversation: https://github.com/opendatahub-io/opendatahub-operator/pull/1304/files#r1806731373 * chore: Make `clean` a PHONY target I believe `clean` should be a PHONY target, since it doesn't create a file called `clean` (cherry picked from commit b91bd29)
Signed-off-by: Wen Zhou <[email protected]>
/test all |
1 similar comment
/test all |
/test opendatahub-operator-e2e |
- we should watch IngressController from operator.openshift.io, not the k8s ingress - this matched the cache we added in main Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 8ea9ea0)
* chore(linter): update golangci-lint to v1.61.0 * chore(linter): fix findings (cherry picked from commit 87c87ab)
finally! 😂 |
@zdtsw Update in deployment name to match with cpaas-midstream will be included in follow up PR? |
Signed-off-by: Wen Zhou <[email protected]>
updated in new commit, let e2e run and see how it goes |
- this only apply for deplenet odh-model-controller - no need to set it in the default map, a waste Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 1f5af72)
Signed-off-by: Wen Zhou <[email protected]>
Signed-off-by: Wen Zhou <[email protected]>
Signed-off-by: Wen Zhou <[email protected]>
Thanks for the changes! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
apart from listed jira,
Jira list
to fix:
https://issues.redhat.com/browse/RHOAIENG-14768
https://issues.redhat.com/browse/RHOAIENG-14120
including:
How Has This Been Tested?
local build: quay.io/wenzhou/rhods-operator-catalog:v2.16.14768-2
install catalogsource
run e2e
Screenshot or short clip
Merge criteria