Skip to content

Commit

Permalink
Tidy up run-nowebhook recipe & make clean PHONY (opendatahub-io#1310)
Browse files Browse the repository at this point in the history
* chore: Tidy run-nowebhook recipe

The suggestion to tidy up the run-nowebhook recipe comes from this
conversation:
https://github.com/opendatahub-io/opendatahub-operator/pull/1304/files#r1806731373

* chore: Make `clean` a PHONY target

I believe `clean` should be a PHONY target, since it doesn't create a
file called `clean`
  • Loading branch information
grdryn authored Oct 21, 2024
1 parent 578d73e commit b91bd29
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,7 @@ run: manifests generate fmt vet ## Run a controller from your host.

.PHONY: run-nowebhook
run-nowebhook: GO_RUN_ARGS += -tags nowebhook
run-nowebhook: manifests generate fmt vet ## Run a controller from your host without webhook enabled
$(GO_RUN_MAIN)
run-nowebhook: run ## Run a controller from your host without webhook enabled

.PHONY: image-build
image-build: # unit-test ## Build image with the manager.
Expand Down Expand Up @@ -380,6 +379,7 @@ CLEANFILES += cover.out
e2e-test: ## Run e2e tests for the controller
go test ./tests/e2e/ -run ^TestOdhOperator -v --operator-namespace=${OPERATOR_NAMESPACE} ${E2E_TEST_FLAGS}

.PHONY: clean
clean: $(GOLANGCI_LINT)
$(GOLANGCI_LINT) cache clean
chmod u+w -R $(LOCALBIN) # envtest makes its dir RO
Expand Down

0 comments on commit b91bd29

Please sign in to comment.