Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

components, logger: use contextual logging approach #1253

Merged
merged 1 commit into from
Oct 17, 2024
Merged

components, logger: use contextual logging approach #1253

merged 1 commit into from
Oct 17, 2024

Commits on Oct 4, 2024

  1. components, logger: use contextual logging approach 

    Switch ReconcileComponent from passing logger explicitly to wrapping
it into context[1][2]

Makes one parameter less to pass and will allow called utilities to
report component context where they are called from.

No user or logging format impact until utilities takes contextual
logging in use.

[1] https://www.kubernetes.dev/blog/2022/05/25/contextual-logging/
[2] https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/3077-contextual-logging/README.md

Credits-To: Bartosz Majsak [email protected]
Signed-off-by: Yauheni Kaliuta <[email protected]>
    @ykaliuta
    ykaliuta committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    28d44be View commit details
    Browse the repository at this point in the history