components, logger: use contextual logging approach #1253
Conversation
ykaliuta
force-pushed
the
logger-components
branch
from
bd1e167
to
adce0b4
Compare
|
/cc @bartoszmajsak would like to implement your proposal. May be it makes sense to do it on startup and controller reconciler's levels from the beginning? Also, I'm wondering what are the reasons of such a different configuration for controllers and components. (consequence, I need to enable devel to get Info from components, otherwise former Info from waitfordeployment is not seen. /cc @zdtsw @lburgazzoli |
zdtsw
requested review from
bartoszmajsak
and removed request for
CFSNM and
biswassri
ykaliuta
force-pushed
the
logger-components
branch
2 times, most recently
from
11a2300
to
adce0b4
Compare
Switch ReconcileComponent from passing logger explicitly to wrapping it into context[1][2] Makes one parameter less to pass and will allow called utilities to report component context where they are called from. No user or logging format impact until utilities takes contextual logging in use. [1] https://www.kubernetes.dev/blog/2022/05/25/contextual-logging/ [2] https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/3077-contextual-logging/README.md Credits-To: Bartosz Majsak [email protected] Signed-off-by: Yauheni Kaliuta <[email protected]>
ykaliuta
force-pushed
the
logger-components
branch
from
adce0b4
to
28d44be
Compare
ykaliuta
changed the title
|
LGTM, I let @zdtsw doing the final review :) |
|
@zdtsw any concerns? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
openshift-merge-bot
bot
merged commit fa862a1
into
opendatahub-io:incubation
Jira: https://issues.redhat.com/browse/RHOAIENG-14366
Switch ReconcileComponent from passing logger explicitly to wrapping
it into context[1][2]
Makes one parameter less to pass and will allow called utilities to
report component context where they are called from.
No user or logging format impact until utilities takes contextual
logging in use.
[1] https://www.kubernetes.dev/blog/2022/05/25/contextual-logging/
[2] https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/3077-contextual-logging/README.md
Credits-To: Bartosz Majsak [email protected]
Signed-off-by: Yauheni Kaliuta [email protected]
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria