Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update namespace of webhook to be set dynamically #237

Merged
merged 1 commit into from
Jul 22, 2024
Merged

update namespace of webhook to be set dynamically #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/base/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,4 @@ vars:
objref:
apiVersion: v1
kind: ConfigMap
name: odh-model-controller-parameters
name: odh-model-controller-parameters
3 changes: 3 additions & 0 deletions config/overlays/odh/params.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ varReference:
- path: objects[]/spec/containers[]/image
kind: Template
apiVersion: template.openshift.io/v1
- path: webhooks/clientConfig[]/service/namespace
kind: ValidatingWebhookConfiguration
apiVersion: admissionregistration.k8s.io/v1
2 changes: 1 addition & 1 deletion config/webhook/manifests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ webhooks:
clientConfig:
service:
name: webhook-service
namespace: system
namespace: $(mesh-namespace)
path: /validate-serving-knative-dev-v1-service
failurePolicy: Fail
name: validating.ksvc.odh-model-controller.opendatahub.io
Expand Down