Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update namespace of webhook to be set dynamically #237

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Jooho
Copy link
Contributor

@Jooho Jooho commented Jul 16, 2024

Description

Webhook clientConfig namespace is not set dynamically and it affects e2e tests for kserve.
This PR uses params.env to set the namespace in the webhook object.

How Has This Been Tested?

kustomize build ./config/base > /tmp/a.yaml

grep namespace /tmp/a.yaml

if don't see mesh-namespace, it succeeds.

expected output:

  namespace: opendatahub
  namespace: opendatahub
  - namespaces
  namespace: opendatahub
  namespace: opendatahub
  namespace: opendatahub
  namespace: opendatahub
  namespace: opendatahub
  namespace: opendatahub
  namespace: opendatahub
  namespace: opendatahub
  namespace: opendatahub
              fieldPath: metadata.namespace
  namespace: opendatahub
  namespace: opendatahub
  namespace: opendatahub
  namespace: opendatahub
  namespace: opendatahub
  namespace: opendatahub
  namespace: opendatahub
  namespace: opendatahub
      namespace: opendatahub

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@Jooho Jooho force-pushed the update_webhook_ns branch 2 times, most recently from 7871a84 to 512365e Compare July 16, 2024 04:41
@lazarotti lazarotti removed the request for review from israel-hdez July 18, 2024 00:53
Copy link
Contributor

@VedantMahabaleshwarkar VedantMahabaleshwarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho, mwaykole, spolti, VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jooho,VedantMahabaleshwarkar,spolti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 21747c9 into opendatahub-io:main Jul 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants