UX updates for content and behavior in event log modal for a starting workbench

[DaoDaoNoCode]

JIRA: https://issues.redhat.com/browse/RHOAIENG-14737

Description

Update several places:

1. Update the waiting message from "Waiting for notebook to start..." to "Waiting for workbench to start..." and the popover title from "Notebook status" to "Workbench status"

2. Update the event modal title from "Starting server" to "Starting workbench" and Update the cancel button text from "Cancel" to "Stop workbench"

3. When stop workbench from the event modal, it will also prompt a confirmation modal now

How Has This Been Tested?

1. Create a workbench
2. Start and stop it, check the event modal
3. Make sure all the content and behavior are as described

Test Impact

Updated some cypress tests to adapt to the change

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[DaoDaoNoCode]

@jgiardino Could you check the screenshots above? Thanks!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (5d82663) to head (fdd9e33).
Report is 23 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3401   +/-   ##
=======================================
  Coverage   85.14%   85.15%           
=======================================
  Files        1338     1338           
  Lines       30122    30118    -4     
  Branches     8270     8269    -1     
=======================================
- Hits        25647    25646    -1     
+ Misses       4475     4472    -3     

Files with missing lines	Coverage Δ
...rc/pages/projects/notebook/NotebookStateStatus.tsx	70.00% <100.00%> (ø)
...src/pages/projects/notebook/StartNotebookModal.tsx	4.83% <ø> (+0.29%)	⬆️
...ects/screens/detail/notebooks/NotebookTableRow.tsx	88.05% <ø> (ø)
...reens/projects/ProjectTableRowNotebookTableRow.tsx	79.48% <ø> (ø)

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d82663...fdd9e33. Read the comment docs.

[pnaik1]

FYI, data test IDs were updated as a result of this PR
@manosnoam

[pnaik1]

Tested in the live cluster
all the content and behaviors works as expected

Just a small comment:
https://github.com/opendatahub-io/odh-dashboard/pull/3401/files#diff-ed8131a3c29c559bbe0d910b599e583b4589517174c05d0bc13a7d48a014dec8L49-R58 this
We do have another location to change, but this isn't displayed in the UI because the modal only opens when the workbench is starting. Can we consider removing this piece of code?

[jgiardino]

Thanks for making these updates, @DaoDaoNoCode! These look good to me.

[DaoDaoNoCode]

@pnaik1 That makes sense, I deleted that chunk on code. Also I reverted the change to the data-testid because I think it would be easier for QE automation and it won't affect anything. FYI @manosnoam Nothing needs to be changed from your side.

[pnaik1]

@DaoDaoNoCode thanks for the changes
/lgtm

[Gkrumbach07]

/lgtm

tested and working as expected

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [Gkrumbach07]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment