Skip to content

Commit

Permalink
UX updates for content and behavior in event log modal for a starting…
Browse files Browse the repository at this point in the history
… workbench
  • Loading branch information
DaoDaoNoCode committed Oct 29, 2024
1 parent 4842b35 commit fe7e942
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion frontend/src/__tests__/cypress/cypress/pages/workbench.ts
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ class NotebookRow extends TableRow {
}

findNotebookStatusPopover(name: string) {
return cy.findByTestId('notebook-status-popover').contains(name);
return cy.findByTestId('workbench-status-popover').contains(name);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ describe('Workbench page', () => {
{ op: 'remove', path: '/metadata/annotations/kubeflow-resource-stopped' },
]);
});
notebookRow.findNotebookStatusPopover('Waiting for notebook to start...').should('exist');
notebookRow.findNotebookStatusPopover('Waiting for workbench to start...').should('exist');
});

it('Validate the start button is enabled when the notebook image is deleted', () => {
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/pages/projects/notebook/NotebookStateStatus.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,14 @@ const NotebookStateStatus: React.FC<NotebookStateStatusProps> = ({
return (
<>
<Popover
data-testid="notebook-status-popover"
data-testid="workbench-status-popover"
shouldClose={() => setPopoverVisible(false)}
isVisible={isPopoverVisible}
headerContent="Notebook status"
headerContent="Workbench status"
bodyContent={
events[events.length - 1]
? getEventFullMessage(events[events.length - 1])
: 'Waiting for notebook to start...'
: 'Waiting for workbench to start...'
}
footerContent={
<Button
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/pages/projects/notebook/StartNotebookModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ const StartNotebookModal: React.FC<StartNotebookModalProps> = ({
onClick={() => onClose(true)}
isDisabled={!open}
>
Cancel
Stop workbench
</Button>
) : (
<NotebookRouteLink
Expand Down Expand Up @@ -178,11 +178,11 @@ const StartNotebookModal: React.FC<StartNotebookModalProps> = ({

return (
<Modal
aria-label="Starting server modal"
aria-label="Starting workbench modal"
description="Depending on the size and resources requested, this can take several minutes."
appendTo={document.body}
variant={ModalVariant.small}
title="Starting server"
title="Starting workbench"
isOpen
showClose
onClose={() => onClose(false)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ const NotebookTableRow: React.FC<NotebookTableRowProps> = ({
</Td>
) : null}
<Td dataLabel="Status">
<NotebookStateStatus notebookState={obj} stopNotebook={handleStop} />
<NotebookStateStatus notebookState={obj} stopNotebook={onStop} />
</Td>
<Td>
<NotebookStateAction
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const ProjectTableRowNotebookTableRow: React.FC<ProjectTableRowNotebookTableRowP
/>
</Td>
<Td dataLabel="Status">
<NotebookStateStatus notebookState={notebookState} stopNotebook={handleStop} />
<NotebookStateStatus notebookState={notebookState} stopNotebook={onStop} />
</Td>
<Td>
<NotebookStateAction
Expand Down

0 comments on commit fe7e942

Please sign in to comment.