Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHOAIENG-8837] Truncate min width issue #2933

Merged
merged 1 commit into from
Jun 21, 2024
Merged

[RHOAIENG-8837] Truncate min width issue #2933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/concepts/pipelines/content/pipelinesDetails/PipelineDetailsTitle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ const PipelineDetailsTitle: React.FC<RunJobTitleProps> = ({
<>
<Split hasGutter>
<SplitItem>
<Truncate content={run.display_name} />
{/* TODO: Remove the custom className after upgrading to PFv6 */}
<Truncate content={run.display_name} className="truncate-no-min-width" />
</SplitItem>
{pipelineRunLabel && (
<SplitItem>
Expand Down
20 changes: 17 additions & 3 deletions frontend/src/concepts/pipelines/content/pipelinesDetails/pipeline/PipelineDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,28 @@ const PipelineDetails: PipelineCoreDetailsPageComponent = ({ breadcrumbPath }) =
<Breadcrumb>
{breadcrumbPath}
<BreadcrumbItem style={{ maxWidth: 300 }}>
<Truncate content={pipeline?.display_name || 'Loading...'} />
{/* TODO: Remove the custom className after upgrading to PFv6 */}
<Truncate
content={pipeline?.display_name || 'Loading...'}
className="truncate-no-min-width"
/>
</BreadcrumbItem>
<BreadcrumbItem isActive style={{ maxWidth: 300 }}>
<Truncate content={pipelineVersion?.display_name || 'Loading...'} />
{/* TODO: Remove the custom className after upgrading to PFv6 */}
<Truncate
content={pipelineVersion?.display_name || 'Loading...'}
className="truncate-no-min-width"
/>
</BreadcrumbItem>
</Breadcrumb>
}
title={<Truncate content={pipelineVersion?.display_name || 'Loading...'} />}
title={
<Truncate
content={pipelineVersion?.display_name || 'Loading...'}
// TODO: Remove the custom className after upgrading to PFv6
className="truncate-no-min-width"
/>
}
{...(pipelineVersion && {
description: (
<MarkdownView
Expand Down
9 changes: 7 additions & 2 deletions frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,14 +138,19 @@ const PipelineRunDetails: PipelineCoreDetailsPageComponent = ({ breadcrumbPath,
version.pipeline_version_id,
)}
>
<Truncate content={version.display_name} />
{/* TODO: Remove the custom className after upgrading to PFv6 */}
<Truncate content={version.display_name} className="truncate-no-min-width" />
</Link>
) : (
'Loading...'
)}
</BreadcrumbItem>
<BreadcrumbItem isActive style={{ maxWidth: 300 }}>
<Truncate content={run?.display_name ?? 'Loading...'} />
{/* TODO: Remove the custom className after upgrading to PFv6 */}
<Truncate
content={run?.display_name ?? 'Loading...'}
className="truncate-no-min-width"
/>
</BreadcrumbItem>
</Breadcrumb>
}
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/concepts/pipelines/content/tables/experiment/ExperimentTableRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ const ExperimentTableRow: React.FC<ExperimentTableRowProps> = ({
}`}
state={{ experiment }}
>
<Truncate content={experiment.display_name} />
{/* TODO: Remove the custom className after upgrading to PFv6 */}
<Truncate content={experiment.display_name} className="truncate-no-min-width" />
</Link>
</Td>
<Td dataLabel="Description">{experiment.description}</Td>
Expand Down
6 changes: 5 additions & 1 deletion frontend/src/pages/pipelines/global/runs/GlobalPipelineVersionRuns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ const GlobalPipelineVersionRuns: PipelineCoreDetailsPageComponent = ({ breadcrum
{breadcrumbPath}
<BreadcrumbItem isActive style={{ maxWidth: 300 }}>
<Link to={routePipelineDetailsNamespace(namespace, pipelineId, pipelineVersionId)}>
<Truncate content={pipelineVersion?.display_name || 'Loading...'} />
{/* TODO: Remove the custom className after upgrading to PFv6 */}
<Truncate
content={pipelineVersion?.display_name || 'Loading...'}
className="truncate-no-min-width"
/>
</Link>
</BreadcrumbItem>
<BreadcrumbItem isActive>Runs</BreadcrumbItem>
Expand Down
Loading