Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-8837] Truncate min width issue #2933

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

dpanshug
Copy link
Contributor

Closes: RHOAIENG-8837

Description

Added inline styling for solve truncate min width issue.

Screenshot 2024-06-20 at 7 59 32 PM
Screenshot 2024-06-20 at 7 59 51 PM

How Has This Been Tested?

Check page title and breadcrumbs in pipeline pages.

Test Impact

None, just a css change

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main
    @yannnz

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.53%. Comparing base (543146f) to head (7a18c82).
Report is 7 commits behind head on main.

Current head 7a18c82 differs from pull request most recent head 26bbd62

Please upload reports for the commit 26bbd62 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2933      +/-   ##
==========================================
- Coverage   78.54%   78.53%   -0.01%     
==========================================
  Files        1138     1138              
  Lines       24137    24137              
  Branches     6092     6092              
==========================================
- Hits        18959    18957       -2     
- Misses       5178     5180       +2     
Files Coverage Δ
.../content/pipelinesDetails/PipelineDetailsTitle.tsx 92.85% <ø> (ø)
...tent/pipelinesDetails/pipeline/PipelineDetails.tsx 90.00% <100.00%> (+1.66%) ⬆️
...ipelinesDetails/pipelineRun/PipelineRunDetails.tsx 80.35% <100.00%> (ø)
...s/content/tables/experiment/ExperimentTableRow.tsx 100.00% <ø> (ø)
...ipelines/global/runs/GlobalPipelineVersionRuns.tsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 543146f...26bbd62. Read the comment docs.

@pnaik1
Copy link
Contributor

pnaik1 commented Jun 21, 2024

Truncate min width issue is fixed
Working as expected
/lgtm
Screenshot 2024-06-21 at 4 36 59 PM

Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested breadcrumbs and page titles in UI - LGTM @dpanshug 👍

Can we add a TODO comment to indicate that we can remove those instances of className once PFv6 is consumed by RHOAI?

@Gkrumbach07
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3d62686 into opendatahub-io:main Jun 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants