-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-8837] Truncate min width issue #2933
[RHOAIENG-8837] Truncate min width issue #2933
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2933 +/- ##
==========================================
- Coverage 78.54% 78.53% -0.01%
==========================================
Files 1138 1138
Lines 24137 24137
Branches 6092 6092
==========================================
- Hits 18959 18957 -2
- Misses 5178 5180 +2
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested breadcrumbs and page titles in UI - LGTM @dpanshug 👍
Can we add a TODO
comment to indicate that we can remove those instances of className
once PFv6 is consumed by RHOAI?
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-8837
Description
Added inline styling for solve truncate min width issue.
How Has This Been Tested?
Check page title and breadcrumbs in pipeline pages.
Test Impact
None, just a css change
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
@yannnz