-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipelines Topology: Support Groups #2725
Pipelines Topology: Support Groups #2725
Conversation
588da35
to
354224d
Compare
frontend/src/concepts/pipelines/topology/usePipelineTaskTopology.ts
Outdated
Show resolved
Hide resolved
dbdff90
to
c5e1e4a
Compare
494d201
to
d8cb226
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Some tasks seem to produce this kind of data {
"type": "groupTask",
"name": "importer",
"steps": [
null
],
"inputs": {
"params": [
{
"label": "uri",
"type": "STRING"
}
]
},
"outputs": {
"artifacts": [
{
"label": "artifact",
"type": "system.Artifact (0.0.1)"
}
]
},
"volumeMounts": []
} where steps can be an array of null or undefined values for some reason. So here is the pipeline that will produce the node. it is the importer node |
frontend/src/concepts/pipelines/topology/usePipelineTaskTopology.ts
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/topology/usePipelineTaskTopology.ts
Outdated
Show resolved
Hide resolved
b7cd29a
to
fa4c00a
Compare
4907d21
to
10d4cf3
Compare
Type simplifications (#6) * Type simplifications * use runStatus to render the icons --------- Co-authored-by: Jenny <[email protected]> add withSelection to graph update popover tasks list to only show status for runs format PipelineDefaultTaskGroup PR feedback from Gage, add params pass executions and updaet icon alignment fix tests Gage test fix fix linting issues status and edge updates
f6bd197
to
d659c03
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Closes https://issues.redhat.com/browse/RHOAIENG-3977
Description
Adds support for groups rendering, selectable, and collapsible groups in Pipelines and Runs Topology view.
How Has This Been Tested?
Tested groups layout, rendering subtasks, and expandable/collapsible functionality in UI.
Test Impact
Tests will be added in a PR for https://issues.redhat.com/browse/RHOAIENG-5146
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main