Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipelines Topology: Support Groups #2725

Merged

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Apr 18, 2024

Closes https://issues.redhat.com/browse/RHOAIENG-3977

Description

Adds support for groups rendering, selectable, and collapsible groups in Pipelines and Runs Topology view.

Screenshot 2024-04-24 at 5 36 47 PM

How Has This Been Tested?

Tested groups layout, rendering subtasks, and expandable/collapsible functionality in UI.

Test Impact

Tests will be added in a PR for https://issues.redhat.com/browse/RHOAIENG-5146

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@jenny-s51 jenny-s51 force-pushed the supportPipelineGroups branch 3 times, most recently from 588da35 to 354224d Compare April 24, 2024 21:34
@jenny-s51 jenny-s51 force-pushed the supportPipelineGroups branch 2 times, most recently from dbdff90 to c5e1e4a Compare April 26, 2024 15:05
@jenny-s51 jenny-s51 force-pushed the supportPipelineGroups branch 2 times, most recently from 494d201 to d8cb226 Compare April 26, 2024 16:04
Copy link
Contributor

@jeff-phillips-18 jeff-phillips-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Gkrumbach07
Copy link
Member

Some tasks seem to produce this kind of data

{
    "type": "groupTask",
    "name": "importer",
    "steps": [
        null
    ],
    "inputs": {
        "params": [
            {
                "label": "uri",
                "type": "STRING"
            }
        ]
    },
    "outputs": {
        "artifacts": [
            {
                "label": "artifact",
                "type": "system.Artifact (0.0.1)"
            }
        ]
    },
    "volumeMounts": []
}

where steps can be an array of null or undefined values for some reason. So PipelineTaskDetails throws a runtime error.

here is the pipeline that will produce the node. it is the importer node
Pipeline time-series-dense-encoder-forecasting.yaml.zip

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Apr 30, 2024
@Gkrumbach07
Copy link
Member

I am seeing these errors and warnings in the console. not sure if where this came from.

Screenshot 2024-04-29 at 8 43 47 PM
Screenshot 2024-04-29 at 8 43 38 PM

Type simplifications (#6)

* Type simplifications

* use runStatus to render the icons

---------

Co-authored-by: Jenny <[email protected]>

add withSelection to graph

update popover tasks list to only show status for runs

format PipelineDefaultTaskGroup

PR feedback from Gage, add params

pass executions and updaet icon alignment

fix tests

Gage test fix

fix linting issues

status and edge updates
@Gkrumbach07
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented May 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 2, 2024
@Gkrumbach07
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b100e97 into opendatahub-io:main May 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants