Custom pipeline groups #5
Conversation
remove unused params translate artifact node add Jeff fixes expose monitoring icon for metric artifacts Artifact node fixes add groups logic to render collapsed group node styling remove groups logic, fix icon color remove PipelineTaskGroup remove unused TaskGroupTargetAnchor fix artifact node dimensions fix linting issues add support for nested pipeline groups, wip run --fix add status to artifact nodes and fix hovered/selected icon color delete IconTaskNode remove custom-topology-components.css use forEach revert tsconfig to es5
jenny-s51
force-pushed
the
customPipelineGroups
branch
from
ff9dad1
to
2a99aec
Compare
| const childCount = element.getAllNodeChildren().length; | ||
| const data = element.getData(); | ||
|
|
||
| const handleCollapse = action((group: Node, collapsed: boolean): void => { |
There was a problem hiding this comment.
This will get done in the DefaultTaskGroup for expanded groups. Remove this here and move it to PipelineTaskGroupCollapsed.
| } | ||
| }); | ||
|
|
||
| if (element.isCollapsed()) { |
There was a problem hiding this comment.
Add a comment that this is temporary until patternfly/react-topology#171 is completed.
There was a problem hiding this comment.
PR with comment to clarify current collapsible support: patternfly/react-topology#176
| labelPosition?: LabelPosition; // Defaults to bottom | ||
| badge?: string; | ||
| } & CollapsibleGroupProps & | ||
| WithSelectionProps; |
There was a problem hiding this comment.
Only take the props that are being passed, not need to take those that are never being set.
| @@ -0,0 +1,19 @@ | |||
| import { AbstractAnchor, Point, Node } from '@patternfly/react-topology'; | |||
|
|
|||
| export default class IconSourceAnchor<E extends Node = Node> extends AbstractAnchor { | |||
There was a problem hiding this comment.
Nope, nice catch - removed this file
|
|
||
| getReferencePoint(): Point { | ||
| const bounds = this.owner.getBounds(); | ||
| return new Point(bounds.x + this.size, bounds.y + bounds.height / 2); |
There was a problem hiding this comment.
This would only work for horizontal layouts
| return withPanZoom()(GraphComponent); | ||
| } | ||
| switch (type) { | ||
| case 'Execution': |
| ]} | ||
| collapsedHeight={NODE_HEIGHT} | ||
| collapsedWidth={NODE_WIDTH} | ||
| {...rest} |
There was a problem hiding this comment.
No need for this
| {...rest} |
| }; | ||
|
|
||
| const DefaultTaskGroupInner: React.FunctionComponent<PipelinesDefaultGroupInnerProps> = observer( | ||
| ({ element, onCollapseChange, selected, onSelect, ...rest }) => { |
There was a problem hiding this comment.
| ({ element, onCollapseChange, selected, onSelect, ...rest }) => { | |
| ({ element, onCollapseChange, selected, onSelect }) => { |
| showStatusState?: boolean; | ||
| status?: RunStatus; | ||
| hiddenDetailsShownStatuses?: RunStatus[]; | ||
| hideDetailsAtMedium?: boolean; | ||
| onCollapseChange?: (group: Node, collapsed: boolean) => void; |
There was a problem hiding this comment.
| showStatusState?: boolean; | |
| status?: RunStatus; | |
| hiddenDetailsShownStatuses?: RunStatus[]; | |
| hideDetailsAtMedium?: boolean; | |
| onCollapseChange?: (group: Node, collapsed: boolean) => void; |
None of these are ever passed
| import { getNodeStatusIcon } from './utils'; | ||
|
|
||
| type PipelinesDefaultGroupProps = { | ||
| children?: React.ReactNode; |
There was a problem hiding this comment.
| children?: React.ReactNode; |
| visualizationController.registerComponentFactory(pipelineComponentFactory); | ||
| visualizationController.registerComponentFactory(pipelineGroupsComponentFactory); |
There was a problem hiding this comment.
If you are including pipelineComponentFactory then pipelineGroupsComponentFactory does not need to duplicate the types in its switch statement. PF will check all factories in reverse order added, so only overrides need to be in the later factories.
If you add the PF pipelines factory (first), you could also remove the DEFAULT_SPACER_NODE_TYPE and DEFAULT_EDGE_TYPE cases.
There was a problem hiding this comment.
Great point, thank you @jeff-phillips-18 . I've addressed this comment and your suggestions above in opendatahub-io#2725
Adds subgraph support, collapsible groups, scaled group nodes, hoverable logic
https://issues.redhat.com/browse/RHOAIENG-3977