Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove modelserving Templates CR folder #2706

Merged
merged 1 commit into from
May 30, 2024

Conversation

lucferbux
Copy link
Contributor

Closes https://issues.redhat.com/browse/RHOAIENG-2883

Description

Removes the Custom Serving Runtime template folder from dashboard to transfer ownership to the model serving team.

How Has This Been Tested?

No testing from our side, just removing the unused files

Test Impact

No testing coverage needed

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@lucferbux
Copy link
Contributor Author

/hold waiting to https://issues.redhat.com/browse/RHOAIENG-860 to be merged

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Apr 12, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Apr 13, 2024
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on dependant PR: opendatahub-io/odh-model-controller#189

Release hold when it merges.

Copy link
Contributor

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@heyselbi
Copy link
Contributor

@andrewballantyne @lucferbux this PR is ready to be merged. PR in odh-model-controller is merged.

@andrewballantyne
Copy link
Member

/unhold

Model Serving is taking over the manifests, their PR has merged. Unholding.

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label May 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 872dc78 into opendatahub-io:main May 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants