-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OVMS images and template #2553
Conversation
Yep, all looks good to me |
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selbi and Sean have tested it. Rubber stamping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, lucferbux, Xaenalt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Closes: https://issues.redhat.com/browse/RHOAIENG-3469 --> addressed by update SHAs for RHOAI. OVMS ODH images will not be updated for now.
https://issues.redhat.com/browse/RHOAIENG-3355 --> addressed by the
--target_device=AUTO
line in the templatePartially closes: https://issues.redhat.com/browse/RHOAIENG-3052 --> addressed by the
--enable_metrics
line in the templatePartially addresses: https://issues.redhat.com/browse/RHOAIENG-3134 --> updating openvino_ir format to latest and adding now newly supported pytorch format
Description
How Has This Been Tested?
I tested this manually on a ROSA-hosted cluster. New image is working well. And all additional args are verified. Comments have been added in the relevant JIRAs with details.
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main