Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OVMS images and template #2553

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

heyselbi
Copy link
Contributor

@heyselbi heyselbi commented Mar 1, 2024

Closes: https://issues.redhat.com/browse/RHOAIENG-3469 --> addressed by update SHAs for RHOAI. OVMS ODH images will not be updated for now.
https://issues.redhat.com/browse/RHOAIENG-3355 --> addressed by the --target_device=AUTO line in the template
Partially closes: https://issues.redhat.com/browse/RHOAIENG-3052 --> addressed by the --enable_metrics line in the template
Partially addresses: https://issues.redhat.com/browse/RHOAIENG-3134 --> updating openvino_ir format to latest and adding now newly supported pytorch format

Description

How Has This Been Tested?

I tested this manually on a ROSA-hosted cluster. New image is working well. And all additional args are verified. Comments have been added in the relevant JIRAs with details.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@heyselbi
Copy link
Contributor Author

heyselbi commented Mar 1, 2024

cc @Xaenalt @z103cb --> if one of you could give a thumbs up, that would be awesome.

@Xaenalt
Copy link
Member

Xaenalt commented Mar 1, 2024

Yep, all looks good to me

@Xaenalt
Copy link
Member

Xaenalt commented Mar 1, 2024

/lgtm

@Xaenalt
Copy link
Member

Xaenalt commented Mar 1, 2024

/lgtm

Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selbi and Sean have tested it. Rubber stamping.

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, lucferbux, Xaenalt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andrewballantyne,lucferbux]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Xaenalt
Copy link
Member

Xaenalt commented Mar 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1bb32f3 into opendatahub-io:main Mar 1, 2024
6 checks passed
@heyselbi heyselbi deleted the ovms-update branch March 18, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants