Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address 3355 bug in OVMS Kserve Template #2537

Closed
wants to merge 20 commits into from
Closed

Address 3355 bug in OVMS Kserve Template #2537

wants to merge 20 commits into from

Conversation

heyselbi
Copy link
Contributor

Closes: https://issues.redhat.com/browse/RHOAIENG-3355

Description

Addresses the bug reported in https://issues.redhat.com/browse/RHOAIENG-3355 . Updated the OVMS KServe template with additional argument.

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Feb 27, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lucferbux for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@z103cb
Copy link

z103cb commented Feb 28, 2024 •
edited
Loading

@Xaenalt and @heyselbi
do we need this command line flag also?

--metrics_enable

@Xaenalt
Copy link
Member

Xaenalt commented Feb 29, 2024

Yes, worth adding

gitdallas and others added 19 commits March 1, 2024 13:00
@gitdallas @heyselbi
chore(readmes): update dev setup/contrib readmes
3e8a0f5 
Signed-off-by: gitdallas <[email protected]>

chore(readmes): update dev setup/contrib readmes

Signed-off-by: gitdallas <[email protected]>
@ppadti @heyselbi
Add unit test case for pipeline/custom file
fdf0256
@christianvogt @heyselbi
fix hook array stability comparison
4a4208f
@dpanshug @heyselbi
Error when creating new data connection in InferenceService
3b5ddd2
@christianvogt @heyselbi
make explore card clickable with PF work around
0dcf8c7
@lucferbux @heyselbi
Fix error handling for subscriptions in the backend
559ba25
@christianvogt @heyselbi
enable react and jsx eslint rules
dec6568
@christianvogt @heyselbi
wait for dryrun requests in ServingRuntimeList test
8aeaa90
@pnaik1 @heyselbi
added accelerator profile cypress test
7e99980
@pnaik1 @heyselbi
added unit test for errorUtils file
2a5d74d
@manaswinidas @heyselbi
Hidden apps to fix inconsistencies in OdhDocument attributes
42606b4
@lucferbux @heyselbi
Fix an issue with the model server dropdown state
73f5212
@dependabot @heyselbi
Bump actions/upload-artifact from 3 to 4
7050fb2 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@lucferbux @heyselbi
Add e2e tutorial for fraud detection
95824af
@dpanshug @heyselbi
Enable GRPC support for model serving routes
d9b7b1b
@dpanshug @heyselbi
Remove support for creating both Single and multi model custom servin…
86f0756 
…g runtime
@pnaik1 @heyselbi
added project details
2d22b7d
@heyselbi
Update tgis and caikit-tgis images
9c0c6cc 
Signed-off-by: heyselbi <[email protected]>
@heyselbi
Address 3355 bug in OVMS Kserve Template
7df4be1
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Mar 1, 2024
@heyselbi
Copy link
Contributor Author

heyselbi commented Mar 1, 2024

re-opened here #2553

@heyselbi heyselbi closed this Mar 1, 2024
@heyselbi heyselbi deleted the ovms-update-3355 branch March 18, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress This PR is in WIP state needs-rebase PR needs to be rebased
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.