Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving Hard coded secret in repository #2324

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

dpanshug
Copy link
Contributor

@dpanshug dpanshug commented Jan 5, 2024

Closes: RHOAIENG-1283

Description

Created a function to generate a mock SHA token instead of hardcoding it, addressing the Synk issue.

How Has This Been Tested?

Running existing integration and e2e tests

Test Impact

Added unit test for createMockToken

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@dpanshug dpanshug force-pushed the hard-code-secret branch 2 times, most recently from d1d8a9d to e45fdcb Compare January 5, 2024 08:59
@christianvogt
Copy link
Contributor

/retest

@Gkrumbach07
Copy link
Member

/lgtm

looks like tests are acting up again...
/retest

@lucferbux
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3ad3792 into opendatahub-io:main Jan 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants