Resolving Hard coded secret in repository

opendatahub-io · Jan 5, 2024 · e45fdcb · e45fdcb
1 parent 2f7b94e
commit e45fdcb
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/frontend/src/__mocks__/mockStatus.ts b/frontend/src/__mocks__/mockStatus.ts
@@ -1,11 +1,12 @@
 import { StatusResponse } from '~/redux/types';
+import { createMockToken } from '~/utilities/string';
 
 export const mockStatus = (): StatusResponse => ({
   kube: {
     currentContext: 'opendatahub/admin-user-datahub-redhat-com:6443/admin-user',
     currentUser: {
       name: 'admin-user/api-admin-user-dev-datahub-redhat-com:6443',
-      token: 'sha256~9iRWHnXnoQusPNr11Hda_rqwerfasdfQWERasdfasdf',
+      token: createMockToken(),
     },
     namespace: 'opendatahub',
     userName: 'admin-user',

diff --git a/frontend/src/utilities/__tests__/string.spec.ts b/frontend/src/utilities/__tests__/string.spec.ts
@@ -1,4 +1,8 @@
-import { replaceNonNumericPartWithString, replaceNumericPartWithString } from '~/utilities/string';
+import {
+  createMockToken,
+  replaceNonNumericPartWithString,
+  replaceNumericPartWithString,
+} from '~/utilities/string';
 
 describe('replaceNumericPartWithString', () => {
   it('should replace the numeric part of a string with a number', () => {
@@ -71,3 +75,11 @@ describe('replaceNonNumericPartWithString', () => {
     expect(replaceNonNumericPartWithString('1Week', 'Minute')).toBe('1Minute');
   });
 });
+
+describe('createMockToken', () => {
+  it('should generate a valid mock token', () => {
+    const token = createMockToken();
+    const tokenRegex = /^sha256~[a-z0-9]{48}$/i;
+    expect(token).toMatch(tokenRegex);
+  });
+});
diff --git a/frontend/src/utilities/string.ts b/frontend/src/utilities/string.ts
@@ -58,3 +58,9 @@ export const replaceNonNumericPartWithString = (
   }
   return updatedString;
 };
+
+/**
+ * Mocks a token for testing purpose
+ */
+export const createMockToken = (): string =>
+  `sha256~${Array.from({ length: 48 }, () => Math.random().toString(36)[2]).join('')}`;