Cleanup deprecated usage of gpu #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewballantyne
requested changes
Nov 17, 2023
Gkrumbach07
force-pushed
the
cleanup-gpu
branch
from
5ed0379
to
2b94be0
Compare
wording and linter updated naming remove gpuSetting
Gkrumbach07
force-pushed
the
cleanup-gpu
branch
from
2b94be0
to
255562d
Compare
| return getCompatibleAcceleratorIdentifiers(obj).some( | ||
| (accelerator) => accelerator === acceleratorIdentifier, | ||
| ); | ||
| return getCompatibleAcceleratorIdentifiers(obj).some((cr) => cr === acceleratorIdentifier); |
There was a problem hiding this comment.
Weird to call it cr 🤔 But variable names are not the end of the world...
There was a problem hiding this comment.
oh yeah in that area it is weird i agree. should be something like identifier
andrewballantyne
approved these changes
Nov 27, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit c50da8c
into
opendatahub-io:f/accelerator-admin-support
4 checks passed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1894
Description
this pr does the following
/gpuand all related utils, types, frontend services, frontend UI components, hooks that use that api endpointcr(custom resource)How Has This Been Tested?
Test Impact
all tests pass. had to edit delete test bc name of button changed
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
no UI changes, just naming of code. any wording changes have already been verified by Katie
After the PR is posted & before it merges:
main