Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: accelerator feature cleanup #1894

Closed
Gkrumbach07 opened this issue Oct 2, 2023 · 0 comments · Fixed by #2182
Closed

[Feature Request]: accelerator feature cleanup #1894

Gkrumbach07 opened this issue Oct 2, 2023 · 0 comments · Fixed by #2182
Assignees
Labels
feature/accelerator-support All things related to Accelerators kind/enhancement New functionality request (existing augments or new additions) priority/normal An issue with the product; fix when possible

Comments

@Gkrumbach07
Copy link
Member

Gkrumbach07 commented Oct 2, 2023

Feature description

There are small non functionality changing code changes that could be make to make the feature more clear for other collaborators

  • remove deprecated gpu utils and endpoints on the backend and frontend
  • rename top tier models, components, utils, etc to accelerator profiles not accelerators. When we are talking about the accelerator profile crd we should include profile in the name, because without it, it sounds like you are referring to the actual physical hardware of the accelerator.
  • Move acceleratorprofiles model to the dashboard model file

Describe alternatives you've considered

This changes do not add value to the user but to the devs, so no alternatives

Anything else?

No response

@Gkrumbach07 Gkrumbach07 added kind/enhancement New functionality request (existing augments or new additions) untriaged Indicates the newly create issue has not been triaged yet priority/normal An issue with the product; fix when possible labels Oct 2, 2023
@Gkrumbach07 Gkrumbach07 added feature/accelerator-support All things related to Accelerators and removed untriaged Indicates the newly create issue has not been triaged yet labels Oct 2, 2023
@Gkrumbach07 Gkrumbach07 moved this from Untriaged to Dev To do in ODH Dashboard Planning Oct 2, 2023
@Gkrumbach07 Gkrumbach07 self-assigned this Nov 17, 2023
@Gkrumbach07 Gkrumbach07 moved this from Dev To do to Dev In progress in ODH Dashboard Planning Nov 17, 2023
@andrewballantyne andrewballantyne linked a pull request Nov 17, 2023 that will close this issue
7 tasks
@github-project-automation github-project-automation bot moved this from Dev In progress to Done in ODH Dashboard Planning Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/accelerator-support All things related to Accelerators kind/enhancement New functionality request (existing augments or new additions) priority/normal An issue with the product; fix when possible
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant