Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into f/model-serving #2124

Merged
merged 18 commits into from
Nov 10, 2023
Merged

Merge main into f/model-serving #2124

merged 18 commits into from
Nov 10, 2023

Conversation

lucferbux
Copy link
Contributor

No description provided.

DaoDaoNoCode and others added 18 commits August 24, 2023 12:36
Show non-DS projects in the project table
dry run and show error message on storage modal
Support storage size unit and show error message correctly
logic for deprecated images

added tests

fix annotations

made annotations land labels optional

supported disabled wording

unknown state will not use a label

Updated tests, updated UI

fix tests

small fixes

added deleted disabled

loaded always signifies data exists

moved popover
updated tests
Copy link
Contributor

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lucferbux. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Nov 10, 2023
@lucferbux lucferbux merged commit 9fbc49e into f/model-serving Nov 10, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase PR needs to be rebased
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants