-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump d3-color and @patternfly/react-topology in /frontend #1650
Bump d3-color and @patternfly/react-topology in /frontend #1650
Conversation
Bumps [d3-color](https://github.com/d3/d3-color) to 3.1.0 and updates ancestor dependency [@patternfly/react-topology](https://github.com/patternfly/react-topology). These dependencies need to be updated together. Updates `d3-color` from 1.4.1 to 3.1.0 - [Release notes](https://github.com/d3/d3-color/releases) - [Commits](d3/d3-color@v1.4.1...v3.1.0) Updates `@patternfly/react-topology` from 4.91.27 to 5.0.0 - [Release notes](https://github.com/patternfly/react-topology/releases) - [Commits](https://github.com/patternfly/react-topology/commits/v5.0.0) --- updated-dependencies: - dependency-name: d3-color dependency-type: indirect - dependency-name: "@patternfly/react-topology" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Tested. Nothing breaks on my end.
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold There's a breaking change in the library, we'll need further investigation @andrewballantyne |
@andrewballantyne @DaoDaoNoCode we might wanna take a look at this, we might need to update the config for the react-topology library |
The PF topology would need to be bumped to v5 together with all the other PF dependencies, we should hold this PR until we upgrade PF to v5. |
@dependabot rebase |
rebase Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -52,7 +52,7 @@ | |||
"@patternfly/react-icons": "4.93.6", | |||
"@patternfly/react-styles": "4.92.6", | |||
"@patternfly/react-table": "4.112.39", | |||
"@patternfly/react-topology": "^4.91.27", | |||
"@patternfly/react-topology": "^5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are at 5.1.0
OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
[EDIT] ON HOLD UNTIL WE UPGRADE TO PATTERNFLY 5
Bumps d3-color to 3.1.0 and updates ancestor dependency @patternfly/react-topology. These dependencies need to be updated together.
Updates
d3-color
from 1.4.1 to 3.1.0Release notes
Sourced from d3-color's releases.
Commits
7a1573e
3.1.075c19c4
update LICENSEef94e01
update dependencies5e9f757
method shorthande4bc34e
formatHex8 (#103)ac660c6
{rgb,hsl}.clamp() (#102)70e3a04
clamp HSL format (#101)994d8fd
avoid backtracking (#100)7d61bbe
3.0.193bc4ff
related d3/d33; extract copyrights from LICENSEUpdates
@patternfly/react-topology
from 4.91.27 to 5.0.0Release notes
Sourced from
@patternfly/react-topology
's releases.... (truncated)
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.