Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump d3-color and @patternfly/react-topology in /frontend #1650

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 9, 2023

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


[EDIT] ON HOLD UNTIL WE UPGRADE TO PATTERNFLY 5

Bumps d3-color to 3.1.0 and updates ancestor dependency @patternfly/react-topology. These dependencies need to be updated together.

Updates d3-color from 1.4.1 to 3.1.0

Release notes

Sourced from d3-color's releases.

v3.1.0

v3.0.1

  • Make build reproducible.

v3.0.0

  • Adopt type: module.

This package now requires Node.js 12 or higher. For more, please read Sindre Sorhus’s FAQ.

v2.0.0

This release adopts ES2015 language features such as for-of and drops support for older browsers, including IE. If you need to support pre-ES2015 environments, you should stick with d3-color 1.x or use a transpiler.

Commits

Updates @patternfly/react-topology from 4.91.27 to 5.0.0

Release notes

Sourced from @​patternfly/react-topology's releases.

v5.0.0

What's Changed

New Contributors

Full Changelog: patternfly/react-topology@v4.93.6...v5.0.0

prerelease-v5.0.0-prerelease.5

5.0.0-prerelease.5 (2023-07-25)

prerelease-v5.0.0-prerelease.4

5.0.0-prerelease.4 (2023-07-17)

Bug Fixes

  • event: Fix firing of GRAPH_LAYOUT_END_EVENT (de5f843)

prerelease-v5.0.0-prerelease.3

5.0.0-prerelease.3 (2023-07-17)

Bug Fixes

  • event: Update values before firing GRAPH_POSITION_CHANGE_EVENT (924ddb5)

prerelease-v5.0.0-prerelease.2

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [d3-color](https://github.com/d3/d3-color) to 3.1.0 and updates ancestor dependency [@patternfly/react-topology](https://github.com/patternfly/react-topology). These dependencies need to be updated together.


Updates `d3-color` from 1.4.1 to 3.1.0
- [Release notes](https://github.com/d3/d3-color/releases)
- [Commits](d3/d3-color@v1.4.1...v3.1.0)

Updates `@patternfly/react-topology` from 4.91.27 to 5.0.0
- [Release notes](https://github.com/patternfly/react-topology/releases)
- [Commits](https://github.com/patternfly/react-topology/commits/v5.0.0)

---
updated-dependencies:
- dependency-name: d3-color
  dependency-type: indirect
- dependency-name: "@patternfly/react-topology"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Changing some JS deps; could be large work if deps are inter-dependant javascript Pull requests that update Javascript code labels Aug 9, 2023
@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Aug 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@manaswinidas
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. and removed needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI labels Aug 9, 2023
Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested. Nothing breaks on my end.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lucferbux
Copy link
Contributor

/hold

There's a breaking change in the library, we'll need further investigation @andrewballantyne

Screenshot 2023-08-10 at 12 50 33

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Aug 10, 2023
@lucferbux lucferbux removed the lgtm label Aug 10, 2023
@lucferbux
Copy link
Contributor

@andrewballantyne @DaoDaoNoCode we might wanna take a look at this, we might need to update the config for the react-topology library

@DaoDaoNoCode
Copy link
Member

The PF topology would need to be bumped to v5 together with all the other PF dependencies, we should hold this PR until we upgrade PF to v5.

@andrewballantyne andrewballantyne added the pr/no-tests-allowed Added by an official approver - this PR is allowed no tests. Omitted, a test must accompany the PR label Sep 7, 2023
@andrewballantyne
Copy link
Member

@dependabot rebase

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Nov 21, 2023
@openshift-merge-robot
Copy link
Contributor

rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -52,7 +52,7 @@
"@patternfly/react-icons": "4.93.6",
"@patternfly/react-styles": "4.92.6",
"@patternfly/react-table": "4.112.39",
"@patternfly/react-topology": "^4.91.27",
"@patternfly/react-topology": "^5.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are at 5.1.0

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 23, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/frontend/d3-color-and-patternfly/react-topology-3.1.0 branch November 23, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changing some JS deps; could be large work if deps are inter-dependant do-not-merge/hold This PR is hold for some reason javascript Pull requests that update Javascript code needs-rebase PR needs to be rebased ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. pr/no-tests-allowed Added by an official approver - this PR is allowed no tests. Omitted, a test must accompany the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants