Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Upgrade to Patternfly v5 #1694

Closed
andrewballantyne opened this issue Aug 22, 2023 · 6 comments · Fixed by #1901 or #2041
Closed

[Feature Request]: Upgrade to Patternfly v5 #1694

andrewballantyne opened this issue Aug 22, 2023 · 6 comments · Fixed by #1901 or #2041
Assignees
@andrewballantyne @jenny-s51
Labels
dependencies Changing some JS deps; could be large work if deps are inter-dependant infrastructure Anything non feature/* related that improves general working of the Dashboard kind/enhancement New functionality request (existing augments or new additions) migrated priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@andrewballantyne
Copy link
Member

andrewballantyne commented Aug 22, 2023 •
edited
Loading

Status

  • Upgrade odh dashboard to PF5 #1901 is merged, this is the foundation
  • Jupyter Tile has some styling issues
  • From memory -- I think the sidebar navigation is also broken (See DS Projects, DS Project Workloads Form, DS Pipelines Create Run for usecases)
  • Other areas of the application need to be tested

Work is being conducted on the feature branch f/pf5-upgrade -- we will merge this into main when it is sane. Hopefully smaller PRs will be able to be done now to clean up any issues with the UI.

Feature description

Patternfly is now on v5 -- https://www.patternfly.org/

We are still on v4. We should upgrade.

Describe alternatives you've considered

No response

Anything else?

No response
@andrewballantyne andrewballantyne added kind/enhancement New functionality request (existing augments or new additions) untriaged Indicates the newly create issue has not been triaged yet priority/normal An issue with the product; fix when possible labels Aug 22, 2023
@github-project-automation github-project-automation bot moved this to Needs prioritization in ODH Dashboard Planning Aug 22, 2023
@andrewballantyne
Copy link
Member Author

@jenny-s51 Do you know when you'll be able to attempt this upgrade?

@manaswinidas manaswinidas added infrastructure Anything non feature/* related that improves general working of the Dashboard dependencies Changing some JS deps; could be large work if deps are inter-dependant and removed untriaged Indicates the newly create issue has not been triaged yet labels Aug 23, 2023
@manaswinidas manaswinidas moved this from Needs prioritization to To do in ODH Dashboard Planning Aug 23, 2023
@jenny-s51
Copy link
Contributor

jenny-s51 commented Aug 23, 2023 •
edited
Loading

Hi @andrewballantyne , thank you for creating this issue. I started upgrading the ODH dashboard as soon as PF5 was released, however there were some conflicts due to OpenShift dependencies that are pulled in by ODH.

As of right now the PF team is working closely with the OpenShift team to help them upgrade their plugins to v5 as soon as possible. Along with ODH, several other products pull in those plugins as dependencies.

Once OpenShift has upgraded these plugins to v5, it should be smooth sailing for the ODH upgrade and I will plan to continue this effort.

@lucferbux
Copy link
Contributor

Ok, I'm gonna link #1597 here cause @DaoDaoNoCode found out that it was addressed in latest PF5 release.

@andrewballantyne
Copy link
Member Author

A dependabot PR appears to need Patternfly v5 as well. #1650

@jenny-s51 jenny-s51 self-assigned this Oct 2, 2023
@jenny-s51 jenny-s51 mentioned this issue Oct 3, 2023
Merged
7 tasks
@andrewballantyne andrewballantyne moved this from Dev To do to UX In Progress in ODH Dashboard Planning Oct 4, 2023
@manaswinidas manaswinidas mentioned this issue Oct 4, 2023
Closed
@dpanshug dpanshug mentioned this issue Oct 9, 2023
Closed
@andrewballantyne andrewballantyne moved this from UX In Progress to Dev In progress in ODH Dashboard Planning Oct 11, 2023
@jenny-s51 jenny-s51 added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. and removed priority/normal An issue with the product; fix when possible labels Oct 11, 2023
@andrewballantyne
Copy link
Member Author

FWIW, I asked Jenny to do this. Both because I would like to see this merged and to test her permission powers 🙂

@andrewballantyne andrewballantyne self-assigned this Oct 17, 2023
@jenny-s51 jenny-s51 mentioned this issue Oct 20, 2023
Merged
7 tasks
@andrewballantyne andrewballantyne mentioned this issue Oct 31, 2023
Merged
7 tasks
@jenny-s51 jenny-s51 mentioned this issue Nov 15, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Dev In progress to Done in ODH Dashboard Planning Nov 20, 2023
@adnankhan666
Copy link

https://issues.redhat.com/browse/RHOAIENG-1786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewballantyne andrewballantyne

@jenny-s51 jenny-s51

Labels
dependencies Changing some JS deps; could be large work if deps are inter-dependant infrastructure Anything non feature/* related that improves general working of the Dashboard kind/enhancement New functionality request (existing augments or new additions) migrated priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
Internal tracking
Status: Done
ODH Feature Tracking
Status: No status
ODH Dashboard Planning
Archived in project
Milestone
No milestone
5 participants
@andrewballantyne @lucferbux @manaswinidas @jenny-s51 @adnankhan666