Fix metrics submission issue and handle errors #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcreasy
reviewed
Jun 14, 2023
|
lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Re-enable Metrics * Fix Graphs & Configure Infrastructure (#1023) * Rework Inference Metrics & Add Runtime Metrics (invalid quieries) * Add stacked line chart functionality * Trustyai demo phase0 (#1093) * Explainability: Fairness and Bias Metrics (Phase 0) (#1001) (#1006) (#1007) (#1008) - Initial feature set for TrustyAI related UI functionality - Adds tab based navigation to modelServing screen - Adds a bias metrics tab with charts for visualising SPD and DIR metrics - Enhances prometheus query features for accessing TrustyAI data - Enhacements to MetricsChart component making it more configurable * Update key of request name to match trusty backend * Remove unnecessary div and inline style from tooltip * Remove 15 minutes refresh option * Prefer optional prop to type union with undefined * Move function definitions inline * Prefer narrowing over type conversion * Inline tab change handler * Remove toolbar option from ApplicationsPage * Inline domain calculator functions * Move defaultDomainCalculator to utils * Return null instead of undefined * Use threshold label instead of index for key * Add enum for tab keys * Remove magic numbers from domain calculations * Make ResponsePredicate mandatory and add predicate to useQueryRangeResourceData * TrustyAI Client (#1318) * Add support for insecure http requests in development mode * Adds low level API client for TrustyAI service * Adds TrustyAI high level API and contexts * Get scheme of TrustyAI route from k8s data * Add model bias configuration table (#1290) * Add model bias configuration table * rebase and remove mock data * Update Trusty AI client to handle API changes (#1336) (#1337) * Add bias metrics configuration modal (#1343) * Add configuration modal * address comments * get rid of some TODOs and refine the route * Multi-metric display on model bias screen (#1273) (#1349) * Enhancements to model bias screen * Display of multiple bias charts simultaneously * Multi-select component, allowing free text, or select-from-list selection of chartst to display * Ability to collapse / expand individual charts * User selectable refresh rates of chart data * Chart selection and open / closed status is persisted to session cache for life of user's browser session Display user defined threshold values on charts (#1163) * Clean up of bias chart logic * Displays thresholds chosen by user, or defaults if none. * Improves domain and threshold calculation based on user values or defaults * Fix metrics submission issue and handle errors (#1378) * Fix metrics submission issue and handle errors * fix lint issue * use error handler on GET functions * Default and restrict threshold, add tooltips, default duplicate name and set feature flag (#1390) * Default and restrict threshold, add tooltips, default duplicate name and set feature flag * fix lint * add tooltips and dropdown descriptions * clear data when closing configuration modal * really solve deleting issue, make empty table view a common component and apply it everywhere * address comments * Minor enhancements to bias chart (#1386) (#1399) * Adds refresh interval options that match openshift observability dashboard * Show first chart from list, if none selected when user first navigates to bias tab * Use search icon instead of plus for nothing selected empty state * Fix error with calculation of 30 days constant * Deleted charts are removed from session storage * Fixes issue with bias charts auto-refreshing with stale data (#1403) (#1404) * Refactor prometheus queries to remove duplication * Fix graph not refreshing issue * Add code review suggestions * Add performance metrics feature flag and refactor runtime server route (#1413) * Add performance metrics feature flag, refactor runtime server route and solve layout issues * revert some style changes * Model serving metrics renaming (#1421) * Adds support for TrustyAI Operator (#1443) * Adds support for TrustyAI Operator (#1276) * Changes from feedback --------- Co-authored-by: Andrew Ballantyne <[email protected]> Co-authored-by: Andrew Ballantyne <[email protected]> Co-authored-by: Alex Creasy <[email protected]> Co-authored-by: Alex Creasy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1359
Description
privilegedAttribute,unprivilegedAttributeandfavorableOutcometo meet the trusty AI server requirements for data types.How Has This Been Tested?
To test description 1:
Try to create/duplicate a configuration, using the valid attributes to see if you could successfully create one
To test description 2:
Try to create/duplicate a configuration, using the invalid attributes like string for the
privilegedAttributefield to see if you can get the error alert after hitting the submit buttonTo test description 3:
Try to delete an SPD type configuration (You cannot delete that before because the context used the wrong delete function)
To test description 4:
Select to show a metric to display -> Go to the configuration page -> Delete that metric -> Go back to view the metrics chart -> Make sure the selection is removed and the chart is also removed
Test Impact
TBD
Request review criteria: