Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create quality chart #1007

Closed
alexcreasy opened this issue Mar 13, 2023 · 0 comments · Fixed by #1093
Closed

Create quality chart #1007

alexcreasy opened this issue Mar 13, 2023 · 0 comments · Fixed by #1093
Assignees
@alexcreasy
Labels
feature/model-serving Model Serving Feature
Milestone
Explainability Ph...

Comments

@alexcreasy
Copy link
Contributor

alexcreasy commented Mar 13, 2023 •
edited
Loading

Requires:

  • Bias Graph
    • Toolbar
      • Metric selection drop down stubs
      • Feature selection drop down stubs
      • Group selection drop down stubs
    • Test dummy data
@alexcreasy alexcreasy added this to the Explainability Phase 0 milestone Mar 13, 2023
@alexcreasy alexcreasy changed the title Create Quality sub page Create quality chart Mar 13, 2023
This was referenced Mar 13, 2023
Closed
Closed
Closed
@alexcreasy alexcreasy added the feature/model-serving Model Serving Feature label Mar 13, 2023
@alexcreasy alexcreasy removed this from the Explainability Phase 0 milestone Mar 13, 2023
@alexcreasy alexcreasy added this to the Explainability Phase 0 milestone Mar 23, 2023
@alexcreasy alexcreasy moved this from Backlog to In progress in ODH Dashboard Planning Apr 18, 2023
alexcreasy added a commit to alexcreasy/odh-dashboard that referenced this issue Apr 18, 2023
@alexcreasy
Explainability: Fairness and Bias Metrics (Phase 0) (opendatahub-io#1001
97efeb5 
) (opendatahub-io#1006) (opendatahub-io#1007) (opendatahub-io#1008)

  - Initial feature set for TrustyAI related UI functionality
  - Adds tab based navigation to modelServing screen
  - Adds a bias metrics tab with charts for visualising SPD and DIR metrics
  - Enhances prometheus query features for accessing TrustyAI data
  - Enhacements to MetricsChart component making it more configurable
@alexcreasy alexcreasy mentioned this issue Apr 19, 2023
Merged
6 tasks
@alexcreasy alexcreasy moved this from In progress to In review in ODH Dashboard Planning Apr 19, 2023
alexcreasy added a commit to alexcreasy/odh-dashboard that referenced this issue Apr 21, 2023
@alexcreasy
Explainability: Fairness and Bias Metrics (Phase 0) (opendatahub-io#1001
d4f90f6 
) (opendatahub-io#1006) (opendatahub-io#1007) (opendatahub-io#1008)

  - Initial feature set for TrustyAI related UI functionality
  - Adds tab based navigation to modelServing screen
  - Adds a bias metrics tab with charts for visualising SPD and DIR metrics
  - Enhances prometheus query features for accessing TrustyAI data
  - Enhacements to MetricsChart component making it more configurable
@alexcreasy alexcreasy linked a pull request Apr 21, 2023 that will close this issue
Trustyai demo phase0 #1093
Merged
6 tasks
openshift-merge-robot pushed a commit that referenced this issue Apr 25, 2023
@alexcreasy
Trustyai demo phase0 (#1093)
52f85f3 
* Explainability: Fairness and Bias Metrics (Phase 0) (#1001) (#1006) (#1007) (#1008)
  - Initial feature set for TrustyAI related UI functionality
  - Adds tab based navigation to modelServing screen
  - Adds a bias metrics tab with charts for visualising SPD and DIR metrics
  - Enhances prometheus query features for accessing TrustyAI data
  - Enhacements to MetricsChart component making it more configurable

* Update key of request name to match trusty backend

* Remove unnecessary div and inline style from tooltip

* Remove 15 minutes refresh option

* Prefer optional prop to type union with undefined

* Move function definitions inline

* Prefer narrowing over type conversion

* Inline tab change handler

* Remove toolbar option from ApplicationsPage

* Inline domain calculator functions

* Move defaultDomainCalculator to utils

* Return null instead of undefined

* Use threshold label instead of index for key

* Add enum for tab keys

* Remove magic numbers from domain calculations

* Make ResponsePredicate mandatory and add predicate to useQueryRangeResourceData
@github-project-automation github-project-automation bot moved this from In review to Done in ODH Dashboard Planning Apr 25, 2023
openshift-merge-robot pushed a commit that referenced this issue Jun 30, 2023
@DaoDaoNoCode @andrewballantyne @alexcreasy
Bias to incubation (#1449)
bb8e2c5 
* Re-enable Metrics

* Fix Graphs & Configure Infrastructure (#1023)

* Rework Inference Metrics & Add Runtime Metrics (invalid quieries)

* Add stacked line chart functionality

* Trustyai demo phase0 (#1093)

* Explainability: Fairness and Bias Metrics (Phase 0) (#1001) (#1006) (#1007) (#1008)
  - Initial feature set for TrustyAI related UI functionality
  - Adds tab based navigation to modelServing screen
  - Adds a bias metrics tab with charts for visualising SPD and DIR metrics
  - Enhances prometheus query features for accessing TrustyAI data
  - Enhacements to MetricsChart component making it more configurable

* Update key of request name to match trusty backend

* Remove unnecessary div and inline style from tooltip

* Remove 15 minutes refresh option

* Prefer optional prop to type union with undefined

* Move function definitions inline

* Prefer narrowing over type conversion

* Inline tab change handler

* Remove toolbar option from ApplicationsPage

* Inline domain calculator functions

* Move defaultDomainCalculator to utils

* Return null instead of undefined

* Use threshold label instead of index for key

* Add enum for tab keys

* Remove magic numbers from domain calculations

* Make ResponsePredicate mandatory and add predicate to useQueryRangeResourceData

* TrustyAI Client (#1318)

* Add support for insecure http requests in development mode

* Adds low level API client for TrustyAI service

* Adds TrustyAI high level API and contexts

* Get scheme of TrustyAI route from k8s data

* Add model bias configuration table (#1290)

* Add model bias configuration table

* rebase and remove mock data

* Update Trusty AI client to handle API changes (#1336) (#1337)

* Add bias metrics configuration modal (#1343)

* Add configuration modal

* address comments

* get rid of some TODOs and refine the route

* Multi-metric display on model bias screen (#1273) (#1349)

* Enhancements to model bias screen

  * Display of multiple bias charts simultaneously

  * Multi-select component, allowing free text, or select-from-list selection of chartst to display

  * Ability to collapse / expand individual charts

  * User selectable refresh rates of chart data

  * Chart selection and open / closed status is persisted to session cache for life of user's browser session

Display user defined threshold values on charts (#1163)

  * Clean up of bias chart logic

  * Displays thresholds chosen by user, or defaults if none.

  * Improves domain and threshold calculation based on user values or defaults

* Fix metrics submission issue and handle errors (#1378)

* Fix metrics submission issue and handle errors

* fix lint issue

* use error handler on GET functions

* Default and restrict threshold, add tooltips, default duplicate name and set feature flag (#1390)

* Default and restrict threshold, add tooltips, default duplicate name and set feature flag

* fix lint

* add tooltips and dropdown descriptions

* clear data when closing configuration modal

* really solve deleting issue, make empty table view a common component and apply it everywhere

* address comments

* Minor enhancements to bias chart (#1386) (#1399)

* Adds refresh interval options that match openshift observability dashboard

* Show first chart from list, if none selected when user first navigates to bias tab

* Use search icon instead of plus for nothing selected empty state

* Fix error with calculation of 30 days constant

* Deleted charts are removed from session storage

* Fixes issue with bias charts auto-refreshing with stale data (#1403) (#1404)

* Refactor prometheus queries to remove duplication

* Fix graph not refreshing issue

* Add code review suggestions

* Add performance metrics feature flag and refactor runtime server route (#1413)

* Add performance metrics feature flag, refactor runtime server route and solve layout issues

* revert some style changes

* Model serving metrics renaming (#1421)

* Adds support for TrustyAI Operator (#1443)

* Adds support for TrustyAI Operator (#1276)

* Changes from feedback

---------

Co-authored-by: Andrew Ballantyne <[email protected]>
Co-authored-by: Andrew Ballantyne <[email protected]>
Co-authored-by: Alex Creasy <[email protected]>
Co-authored-by: Alex Creasy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcreasy alexcreasy

Labels
feature/model-serving Model Serving Feature
Projects
No open projects
ODH Dashboard Planning
Archived in project
Milestone
Explainability Phase 0
Development

Successfully merging a pull request may close this issue.

Trustyai demo phase0 alexcreasy/odh-dashboard
2 participants
@alexcreasy @andrewballantyne