Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the example elyra runtime Test from notebook images #165

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

harshad16
Copy link
Member

@harshad16 harshad16 commented Aug 10, 2023

Removed the example elyra runtime Test from notebook images

Description

The sample elyra runtime configuration Test is causing confusion for the users.
This PR would remove it, so users don't get confused over the example.

Fixes: #156

How Has This Been Tested?

  1. Run the PR image to start a jupyter notebook
  2. Check for the runtime configuration from the runtime panel.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member

atheo89 commented Aug 11, 2023

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

/test remaining-required

@harshad16
Copy link
Member Author

This is already tested.
Merging this in.

@harshad16 harshad16 merged commit 8c0a7e5 into opendatahub-io:main Aug 16, 2023
harshad16 added a commit to harshad16/odh-notebooks that referenced this pull request Aug 17, 2023
harshad16 added a commit to harshad16/odh-notebooks that referenced this pull request Aug 17, 2023
harshad16 added a commit to harshad16/odh-notebooks that referenced this pull request Aug 17, 2023
@harshad16 harshad16 deleted the rm-test-runtime branch August 17, 2023 15:04
harshad16 referenced this pull request in red-hat-data-services/notebooks Aug 23, 2023
* fix Pipfile.lock exist in container (#153)

* dropped z stream from python version in notebook (#144)

* dropped z stream from python version in notebook

Co-authored-by: dibryant [email protected]

* Add documentation for workbench ImageStreams (#158)

* Removed thamos from package requirements (#157)

* Include github workflow to incldue issue to project (#169)

Signed-off-by: Harshad Reddy Nalla <[email protected]>

* Adjust the OWNERS file with new team members (#168)

Signed-off-by: Harshad Reddy Nalla <[email protected]>

* Removed the example elyra runtime Test from notebook images (#165)

Signed-off-by: Harshad Reddy Nalla <[email protected]>

* Add elyra dependencies for air-gapped environment (#166)

- included runtime-minimal for use in-place of ubi9-py3.9

* Upgrade minio version > 7.1.9 to get the fips requirements (#171)

Signed-off-by: Harshad Reddy Nalla <[email protected]>

* fix pytorch and tensorflow runtime workdir (#173)

Signed-off-by: Harshad Reddy Nalla <[email protected]>

* Set the airgapped env var required by elyra (#172)

Signed-off-by: Harshad Reddy Nalla <[email protected]>

* Update the pipfile.lock via the weekly workflow action

---------

Signed-off-by: Harshad Reddy Nalla <[email protected]>
Co-authored-by: orangeji11 <[email protected]>
Co-authored-by: Diamond Bryant <[email protected]>
Co-authored-by: Marek Laššák <[email protected]>
Co-authored-by: Harshad Reddy Nalla <[email protected]>
Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
harshad16 added a commit to harshad16/odh-notebooks that referenced this pull request Sep 27, 2023
jstourac pushed a commit to jstourac/notebooks that referenced this pull request Mar 3, 2024
sync release-2023b branch with final commit for code-freeze 2.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We may want to remove the "Test" Runtime in the Elyra notebooks
2 participants