Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] hadolint warnings to base and rstudio Dockerfiles #169

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Mar 3, 2024

These changes shouldn't have any functional impact.

This fixes the CI checks and should be cherry-picked to main.


But just now, when raising this. I'm thinking whether we actually want it in the rhoai-2.8 in the end... Please, let me know, guys.

These changes shouldn't have any functional impact.
@jstourac jstourac self-assigned this Mar 3, 2024
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 👍

Copy link

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b6b1314 into red-hat-data-services:rhoai-2.8 Mar 4, 2024
5 checks passed
@riprasad
Copy link
Member

riprasad commented Mar 5, 2024

@harshad16 We are in Code freeze and lets respect the protocol. Please do not accepts any changes in the release branch that doesn't have a blocker JIRA associated with it.

Please reset the branch to point 37e8782

@harshad16
Copy link
Member

@riprasad Thanks for pointing us in the right direction.
we have reverted to commit 37e8782 in https://github.com/red-hat-data-services/notebooks/commits/rhoai-2.8/

@jstourac , please open a separate PR for main.

@jstourac
Copy link
Member Author

jstourac commented Mar 6, 2024

@harshad16 Checking the main and looks like it doesn't contain the changes from upstream yet. I'll wait till it's time to do this then. Thanks.

Update: created #179.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants