[pull] main from kubeflow:main #151
Conversation
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Update Makefile Signed-off-by: root <[email protected]> * Update install_protoc.sh Signed-off-by: root <[email protected]> --------- Signed-off-by: root <[email protected]>
|
Hi @pull[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
=======================================
Coverage 72.54% 72.54%
=======================================
Files 25 25
Lines 2739 2739
Branches 73 73
=======================================
Hits 1987 1987
Misses 540 540
Partials 212 212 ☔ View full report in Codecov by Sentry. |
* fix(isvc): bugs from local testing Signed-off-by: Alessio Pragliola <[email protected]> * chore(isvc): nit rename skip tls verify var in tests Signed-off-by: Alessio Pragliola <[email protected]> * fix(isvc): wrongly overriding the custom http client config Signed-off-by: Alessio Pragliola <[email protected]> * feat(isvc): make skip tls verify controller wise Signed-off-by: Alessio Pragliola <[email protected]> --------- Signed-off-by: Alessio Pragliola <[email protected]>
There was a problem hiding this comment.
- keep build: fix workflow details making it compatible on s390x kubeflow/model-registry#602
- keep fix(isvc): post testing kubeflow/model-registry#603
labels are applied
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pull[bot], tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 162e302
into
opendatahub-io:main
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )