fix(isvc): post testing

[Al-Pragliola]

Description

• moved "url" from label to annotation because of character limits in labels and from a logical point of view it doesn't seem to be a useful field for filtering ref
• introduced "skip-tls-verify" annotation, giving users the option to skip tls verification when using test/dev clusters
• now the controller skips inferenceservices that are missing either the model registry name label or the url annotation

How Has This Been Tested?

tested on a local cluter and with make test

Merge criteria:

• All the commits have been signed-off (To pass the DCO check)

• The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work.
• Code changes follow the kubeflow contribution guidelines.

[tarilabs]

thank you @Al-Pragliola !

small comment for quick check, otherwise

/lgtm

[tarilabs]

open question: this seems a cross-cutting concern of the environment, wouldn't make more sense to make it configurable at the test level/controller level, rather than per-k8s-resource?

I'm wondering if this doesn't open some concern in "prod" as it would allow to define a per-Isvc insecure connection (truly, it's opt-in, but I thought worthy in raising this)

wdyt?

[Al-Pragliola]

yeah you are right, seems like the wrong place to set this field

[tarilabs]

looks more intentional to me, thanks a lot for incorporating the feedback and it's always easy to reconsider this choice eventually if needed

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tarilabs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment