Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge aruco changes from 3.4 to 4.x #3213

Closed
wants to merge 4 commits into from
Closed

merge aruco changes from 3.4 to 4.x #3213

wants to merge 4 commits into from

Conversation

AleksandrPanov
Copy link
Contributor

@AleksandrPanov AleksandrPanov commented Mar 24, 2022 •
edited by asmorkalov
Loading

Merge with extra: opencv/opencv_extra#966

Ported PRs:

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AleksandrPanov AleksandrPanov force-pushed the add_aruco_changes_from_3.4 branch 5 times, most recently from b4701d2 to a81a014 Compare March 25, 2022 03:39
@alalek
Copy link
Member

alalek commented Mar 25, 2022

Merge pull request #XYZ ...

This message format is not allowed in PRs commits. Remove the first line.
Please take a look on existed port/backport PRs - there are no such things.

Avoid creation of unwanted cross-reference links on PRs (you can check that non-removable trash appears in linked PR).
Commit SHA of original commit is enough.

@AleksandrPanov AleksandrPanov force-pushed the add_aruco_changes_from_3.4 branch from f2b730c to aa8acf9 Compare March 25, 2022 09:39
@AleksandrPanov AleksandrPanov force-pushed the add_aruco_changes_from_3.4 branch from a6b0d70 to e912202 Compare March 25, 2022 16:44
@AleksandrPanov
Copy link
Contributor Author

Merge pull request #XYZ ...

This message format is not allowed in PRs commits. Remove the first line. Please take a look on existed port/backport PRs - there are no such things.

Avoid creation of unwanted cross-reference links on PRs (you can check that non-removable trash appears in linked PR). Commit SHA of original commit is enough.

fixed

@AleksandrPanov AleksandrPanov mentioned this pull request Mar 25, 2022
Merged
6 tasks
@alalek alalek mentioned this pull request Mar 26, 2022
Merged
AleksandrPanov
AleksandrPanov commented Apr 8, 2022
View reviewed changes
modules/aruco/test/test_charucodetection.cpp
Comment on lines -684 to -687
cv::Mat K = (cv::Mat_<double>(3,3) <<
0.5*res.width, 0, 0.5*res.width,
0, 0.5*res.height, 0.5*res.height,
0, 0, 1);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not useful for this test

@asmorkalov
Copy link
Contributor

@AleksandrPanov Is the patch still relevant? Could you close it, if not.

@RealOrangeOne
Copy link

Sorry to ping an old PR, but any progress on getting these patches into 4.x? Most of the issues referenced in the issue aren't actually fixed in 4.x because the patches haven't been merged in and are only fixed in 3.x.

@alalek
Copy link
Member

alalek commented Nov 16, 2022

@RealOrangeOne what is wrong with PR #3215 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: aruco
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AleksandrPanov @alalek @asmorkalov @RealOrangeOne