Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aruco improvements #3200

Merged
merged 4 commits into from
Apr 14, 2022
Merged

Aruco improvements #3200

merged 4 commits into from
Apr 14, 2022

Conversation

AleksandrPanov
Copy link
Contributor

@AleksandrPanov AleksandrPanov commented Mar 16, 2022 •
edited
Loading

This PR fixes:

  • readDictionary() and readDetectorParameters() for Python

This PR adds:

  • writeDictionary()
  • add dict distance
  • add dict utils sample

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AleksandrPanov AleksandrPanov mentioned this pull request Mar 17, 2022
Closed
@AleksandrPanov AleksandrPanov linked an issue Mar 17, 2022 that may be closed by this pull request
Unable to detect Aruco marker under some circumstances #3192
Closed
@AleksandrPanov AleksandrPanov removed a link to an issue Mar 18, 2022
Unable to detect Aruco marker under some circumstances #3192
Closed
@AleksandrPanov AleksandrPanov force-pushed the aruco_improvements branch 2 times, most recently from b18c34a to 1b85f01 Compare March 18, 2022 14:06
asmorkalov
asmorkalov requested changes Mar 21, 2022
View reviewed changes
modules/aruco/samples/aruco_dict_utils.cpp Outdated Show resolved Hide resolved
modules/aruco/samples/aruco_dict_utils.cpp Outdated Show resolved Hide resolved
modules/aruco/samples/create_board_charuco.cpp Outdated Show resolved Hide resolved
modules/aruco/src/dictionary.cpp Outdated Show resolved Hide resolved
@AleksandrPanov AleksandrPanov marked this pull request as ready for review March 21, 2022 20:58
@AleksandrPanov AleksandrPanov requested a review from alalek March 22, 2022 21:13
@asmorkalov asmorkalov mentioned this pull request Mar 23, 2022
Closed
@asmorkalov
Copy link
Contributor

@AleksandrPanov Please resolve merge conflicts.

@AleksandrPanov
Copy link
Contributor Author

@AleksandrPanov Please resolve merge conflicts.

fixed

@AleksandrPanov
Copy link
Contributor Author

AleksandrPanov commented Mar 25, 2022 •
edited
Loading

@alalek could you check this PR?
I would cherry-pick commits to PR #3213 after

@AleksandrPanov
Copy link
Contributor Author

@alalek could you check this PR?

This was referenced Apr 12, 2022
Closed
Closed
@opencv-pushbot opencv-pushbot merged commit 76cd35e into opencv:3.4 Apr 14, 2022
AleksandrPanov pushed a commit to AleksandrPanov/opencv_contrib that referenced this pull request Apr 14, 2022
Merge pull request opencv#3200 from AleksandrPanov:aruco_improvements
ea5fb7b 
Aruco improvements

* add writeDictionary(), dict distance, fix readDictionary(), readDetectorParameters()

* add aruco_dict_utils.cpp

* add py test_write_read_dict

* update tutorial
@AleksandrPanov AleksandrPanov mentioned this pull request Apr 14, 2022
Closed
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 16, 2022
Merged
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@alalek alalek Awaiting requested review from alalek

Assignees

@opencv-pushbot opencv-pushbot

Labels
bug category: aruco test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AleksandrPanov @asmorkalov @opencv-pushbot @alalek