Fix broken pyhton binding for sfm importReconstruction #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change signature of the importReconstruction function to allow for correct python bindings to be exported.
PaulDebus
force-pushed
the
sfm_importReconstruction
branch
from
a392764 to
2b8870d
Compare
mshabunin
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change signature of the importReconstruction function to allow for
correct python bindings to be exported.
This pullrequest changes
When using the python bindings exported for
cv2.sfm.importReconstruction, a crash occurs because of a wrong array type like in #1675. After this change, the import works correctly.