change replicas to instances #301

tiansuo114 · 2023-08-27T07:44:25Z

close #146

change the replicas keyword in topoloy.yaml to instances
but also keep the old version,old version topoloy.yaml still can use

other:
Change the replicas keyword displayed after executing the curveadm status command to instances

将 topoloy.yaml 中的replicas关键字更改为instances
但也保留旧版本，旧版本的topoloy.yaml关键字仍然可以使用

其他：
将执行curveadm status命令后显示的replicas关键字改为instances

tiansuo114 · 2023-08-27T07:46:59Z

Sorry I made a terrible mistake in old pull request(change the replicas keyword to service_num #294)😭😭
I have open a new pull request to restart that

Wine93 · 2023-08-27T13:03:56Z

Hi @tiansuo114, have you tested it?

Wine93 · 2023-08-28T01:37:09Z

@tiansuo114 You should also handle some related variables, like service_replicas_sequence and service_replica_sequence.

tiansuo114 · 2023-08-28T06:39:22Z

@tiansuo114 You should also handle some related variables, like service_replicas_sequence and service_replica_sequence.

my mistake😭i will change it

tiansuo114 · 2023-08-30T06:59:49Z

@tiansuo114 You should also handle some related variables, like service_replicas_sequence and service_replica_sequence.

I encountered some problems when changing the fields in LogicalPool in curveadm/internal/configure/pool.go. After I deleted the original replicas field and changed it to instances and compiled and ran it, I encountered a cpp file error, This file comes from curve/tools/curvefsTool.cpp. I don't know if I should change the cpp file or how to deal with this error. I chose to temporarily keep the replicas attribute to solve this problem. For this, I would like to ask for your opinion

The following is the error message I encountered

Error-Code:410019
Error-Description: create logical pool failed
Error-Clue:
E 2023-08-30T14:17:28.23610+0800 134 curvefsTool.cpp:385] logicalpool replicasnum must be uin
E 2023-08-30T14:17:2823646+0800 134 curvefsTool.cpp:132] init logical pool data fail.
E 2023-08-30T14:17:28.023653+0800 134 curvefsTool.cpp:1109] exec fail，ret = -1
How to Solve:

Website: https://github.com/opencurve/curveadm/wiki/errno4#410019
Log: /home/curve/.curveadm/logs/curveadm-2023-08-30_14-15-57.log
WeChat: opencurve_bot

tiansuo114 · 2023-08-30T07:54:06Z

@tiansuo114 You should also handle some related variables, like service_replicas_sequence and service_replica_sequence.

I encountered some problems when changing the fields in LogicalPool in curveadm/internal/configure/pool.go. After I deleted the original replicas field and changed it to instances and compiled and ran it, I encountered a cpp file error, This file comes from curve/tools/curvefsTool.cpp. I don't know if I should change the cpp file or how to deal with this error. I chose to temporarily keep the replicas attribute to solve this problem. For this, I would like to ask for your opinion

The following is the error message I encountered

Error-Code:410019 Error-Description: create logical pool failed Error-Clue: E 2023-08-30T14:17:28.23610+0800 134 curvefsTool.cpp:385] logicalpool replicasnum must be uin E 2023-08-30T14:17:2823646+0800 134 curvefsTool.cpp:132] init logical pool data fail. E 2023-08-30T14:17:28.023653+0800 134 curvefsTool.cpp:1109] exec fail，ret = -1 How to Solve:

Website: https://github.com/opencurve/curveadm/wiki/errno4#410019
Log: /home/curve/.curveadm/logs/curveadm-2023-08-30_14-15-57.log
WeChat: opencurve_bot

By the way, I don’t know if the changes in the source code will affect the image file deployed in curveadm (I guess the error of the cpp file in this file is due to a problem with the execution of the image file in docker), I hope Can you give suggestions for modifications?

Wine93 · 2023-09-01T01:53:22Z

@tiansuo114 You should also handle some related variables, like service_replicas_sequence and service_replica_sequence.

I encountered some problems when changing the fields in LogicalPool in curveadm/internal/configure/pool.go. After I deleted the original replicas field and changed it to instances and compiled and ran it, I encountered a cpp file error, This file comes from curve/tools/curvefsTool.cpp. I don't know if I should change the cpp file or how to deal with this error. I chose to temporarily keep the replicas attribute to solve this problem. For this, I would like to ask for your opinion
The following is the error message I encountered
Error-Code:410019 Error-Description: create logical pool failed Error-Clue: E 2023-08-30T14:17:28.23610+0800 134 curvefsTool.cpp:385] logicalpool replicasnum must be uin E 2023-08-30T14:17:2823646+0800 134 curvefsTool.cpp:132] init logical pool data fail. E 2023-08-30T14:17:28.023653+0800 134 curvefsTool.cpp:1109] exec fail，ret = -1 How to Solve:

Website: https://github.com/opencurve/curveadm/wiki/errno4#410019
Log: /home/curve/.curveadm/logs/curveadm-2023-08-30_14-15-57.log
WeChat: opencurve_bot

By the way, I don’t know if the changes in the source code will affect the image file deployed in curveadm (I guess the error of the cpp file in this file is due to a problem with the execution of the image file in docker), I hope Can you give suggestions for modifications?

Please paste your toplogy.yaml.

Wine93 · 2023-09-01T02:22:07Z

internal/configure/pool.go

@@ -96,7 +97,7 @@ type (
 *   logicalpools:
 *     - name: pool1
 *       physicalpool: pool1
- *       replicasnum: 3
+ *       instancessum: 3


Don't change it, the replicasnum represents the number of copies of the data, not the number of services, this is why we need this PR :)

Wine93 · 2023-09-01T02:22:58Z

internal/configure/pool.go

@@ -119,7 +120,7 @@ type (
 *     ...
 *   pools:
 *     - name: pool1
- *       replicasnum: 3
+ *		 instancessum: 3


Wine93 · 2023-09-01T02:23:44Z

internal/configure/pool.go

+		Name:      logicalPool,
+		Copysets:  copysets,
+		Zones:     zones,
+		Instances: DEFAULT_INSTANCES_PER_COPYSET,


You can delete it.

Signed-off-by: tec-rubbish maker <[email protected]> change topology variable change service_replicas_sequence and format_replicas_sequence to service_instances_sequence and format_instances_sequence Signed-off-by: tec-rubbish maker <[email protected]> fix the worng instances Signed-off-by: tec-rubbish maker <[email protected]> mistake Signed-off-by: tec-rubbish maker <[email protected]>

tiansuo114 · 2023-09-01T03:02:21Z

Ok, I corrected my misunderstanding. After testing, the final version of the code can complete the deployment of the curve_bs cluster. I uploaded the deployment file that I executed in my test environment. If you need it, you can find it here download:
https://github.com/tiansuo114/go-tools/tree/main/curveadm_configs

My test is still not perfect, if you find any other mistakes, please ask me to modify the code again😭😭

Wine93 · 2023-09-01T04:30:31Z

cli/command/status.go

@@ -73,7 +73,7 @@ func NewStatusCommand(curveadm *cli.CurveAdm) *cobra.Command {
 	flags.StringVar(&options.role, "role", "*", "Specify service role")
 	flags.StringVar(&options.host, "host", "*", "Specify service host")
 	flags.BoolVarP(&options.verbose, "verbose", "v", false, "Verbose output for status")
-	flags.BoolVarP(&options.showReplicas, "show-replicas", "s", false, "Display service replicas")
+	flags.BoolVarP(&options.showInstances, "show-instances", "s", false, "Display service num")


Suggested change

flags.BoolVarP(&options.showInstances, "show-instances", "s", false, "Display service num")

flags.BoolVarP(&options.showInstances, "show-instances", "s", false, "Display service instances")

Signed-off-by: Wine93 <[email protected]>

Wine93

LGTM!

Wine93 added the merge to v0.3.0 label Aug 27, 2023

Wine93 added this to the v0.3.0 milestone Aug 27, 2023

Wine93 reviewed Sep 1, 2023

View reviewed changes

Update cli/command/status.go

191900c

Signed-off-by: Wine93 <[email protected]>

caoxianfei1 added the developer activities label Sep 5, 2023

Wine93 approved these changes Sep 11, 2023

View reviewed changes

caoxianfei1 approved these changes Sep 11, 2023

View reviewed changes

caoxianfei1 merged commit 28dd6b0 into opencurve:develop Sep 12, 2023

aspirer mentioned this pull request Nov 24, 2023

playbook memcached add instances and ${instances_sequence} #341

Closed

caoxianfei1 removed the developer activities label Nov 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change replicas to instances #301

change replicas to instances #301

tiansuo114 commented Aug 27, 2023 •

edited by aspirer

Loading

tiansuo114 commented Aug 27, 2023

Wine93 commented Aug 27, 2023

Wine93 commented Aug 28, 2023 •

edited

Loading

tiansuo114 commented Aug 28, 2023

tiansuo114 commented Aug 30, 2023

tiansuo114 commented Aug 30, 2023

Wine93 commented Sep 1, 2023

Wine93 Sep 1, 2023 •

edited

Loading

Wine93 Sep 1, 2023

Wine93 Sep 1, 2023

tiansuo114 commented Sep 1, 2023

Wine93 Sep 1, 2023

Wine93 left a comment

	flags.BoolVarP(&options.showInstances, "show-instances", "s", false, "Display service num")
	flags.BoolVarP(&options.showInstances, "show-instances", "s", false, "Display service instances")

change replicas to instances #301

change replicas to instances #301

Conversation

tiansuo114 commented Aug 27, 2023 • edited by aspirer Loading

tiansuo114 commented Aug 27, 2023

Wine93 commented Aug 27, 2023

Wine93 commented Aug 28, 2023 • edited Loading

tiansuo114 commented Aug 28, 2023

tiansuo114 commented Aug 30, 2023

tiansuo114 commented Aug 30, 2023

Wine93 commented Sep 1, 2023

Wine93 Sep 1, 2023 • edited Loading

Choose a reason for hiding this comment

Wine93 Sep 1, 2023

Choose a reason for hiding this comment

Wine93 Sep 1, 2023

Choose a reason for hiding this comment

tiansuo114 commented Sep 1, 2023

Wine93 Sep 1, 2023

Choose a reason for hiding this comment

Wine93 left a comment

Choose a reason for hiding this comment

tiansuo114 commented Aug 27, 2023 •

edited by aspirer

Loading

Wine93 commented Aug 28, 2023 •

edited

Loading

Wine93 Sep 1, 2023 •

edited

Loading