change the replicas keyword to service_num #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think maybe |
更改Replicas关键字,更新curvebs的topology.yaml Signed-off-by: tec-rubbish maker <[email protected]> Signed-off-by: tec-rubbish maker <[email protected]>
Signed-off-by: tec-rubbish maker <[email protected]> Signed-off-by: tec-rubbish maker <[email protected]>
Signed-off-by: tec-rubbish maker <[email protected]> Signed-off-by: tec-rubbish maker <[email protected]>
Signed-off-by: tec-rubbish maker <[email protected]> Signed-off-by: tec-rubbish maker <[email protected]>
Signed-off-by: tec-rubbish maker <[email protected]> Signed-off-by: tec-rubbish maker <[email protected]>
Signed-off-by: tec-rubbish maker <[email protected]> Signed-off-by: tec-rubbish maker <[email protected]>
Signed-off-by: tec-rubbish maker <[email protected]> Signed-off-by: tec-rubbish maker <[email protected]>
Signed-off-by: tec-rubbish maker <[email protected]>
Okay, I have completed the code change (that is, changed the service_num keyword to instance) and committed the code. Please help conduct a code review for my code. |
Wine93
reviewed
Aug 27, 2023
cli/command/migrate.go
Outdated
| @@ -152,7 +152,7 @@ func checkMigrateTopology(curveadm *cli.CurveAdm, data string) error { | |||
| dcs2add[0].GetRole() != dcs2del[0].GetRole() { | |||
| return errno.ERR_REQUIRE_SAME_ROLE_SERVICES_FOR_MIGRATING | |||
| } | |||
| if len(dcs2del) != dcs2del[0].GetReplicas() { | |||
| if len(dcs2del) != dcs2del[0].GetInstance() { | |||
There was a problem hiding this comment.
Sorry, i didn't express clearly, actually we should use word instances for multi-instances, so GetInstances not GetInstance.
Wine93
reviewed
Aug 27, 2023
cli/command/status.go
Outdated
| type statusOptions struct { | ||
| id string | ||
| role string | ||
| host string | ||
| verbose bool | ||
| showReplicas bool | ||
| showInstance bool |
Wine93
reviewed
Aug 27, 2023
internal/errno/errno.go
Outdated
| ERR_REPLICAS_REQUIRES_POSITIVE_INTEGER = EC(331002, "replicas requires a positive integer") | ||
| ERR_INVALID_VARIABLE_SECTION = EC(331003, "invalid variable section") | ||
| ERR_DUPLICATE_SERVICE_ID = EC(331004, "service id is duplicate") | ||
| //todo: remove ERR_REPLICAS_REQUIRES_POSITIVE_INTEGER and change to ERR_NO_SERVICES_NUM_TOPOLOGY |
There was a problem hiding this comment.
We should update the error code which show below.
|
BTW: please rebase all commits into one when all is ready. |
|
I think i make a mistake in pull request😢😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the replicas keyword in topoloy.yaml to service_num
but also keep the old version,old vversion topoloy.yaml still can use
other:
Change the replicas keyword displayed after executing the curveadm status command to service num
将 topoloy.yaml 中的replicas关键字更改为service_num
但也保留旧版本，旧版本的topoloy.yaml仍然可以使用
其他：
将执行curveadm status命令后显示的replicas关键字改为service num