Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bs delete volume recover&clone command #2713

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

setcy
Copy link
Contributor

@setcy setcy commented Aug 21, 2023

What problem does this PR solve?

add bs delete volume recover and bs delete volume clone command

$ curve bs delete volume clone
+------+--------------------------------------+--------------------------------------+--------+--------+            
| USER |                 SRC                  |               TASK ID                |  FILE  | RESULT |            
+------+--------------------------------------+--------------------------------------+--------+--------+            
| root | a19b5e5e-b306-488f-8e6d-d87282c869cb | d26e27a8-fcbd-4f7a-adf8-53795217cbb0 | /root2 | fail   |            
+------+--------------------------------------+--------------------------------------+--------+--------+  
$ curve bs delete volume recover
+------+--------------------------------------+--------------------------------------+-------+--------+             
| USER |                 SRC                  |               TASK ID                | FILE  | RESULT |             
+------+--------------------------------------+--------------------------------------+-------+--------+             
| root | a19b5e5e-b306-488f-8e6d-d87282c869cb | 9dfa8699-a275-4891-8ec2-e447a0ccc77c | /root | fail   |             
+------+--------------------------------------+--------------------------------------+-------+--------+   

Issue Number:
#2580
#2581

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@setcy setcy marked this pull request as ready for review August 21, 2023 11:34
@lng2020
Copy link
Contributor

lng2020 commented Aug 25, 2023

I believe there is no problem with the logic of the code, but the printing form may need to be standardized. The implementation in your PR is to ask the user yes/no, and then print it line by line, which is different from the printing form of other commands(e.g. print a table with several rows). But how to print is not up to me, ask @Cyber-SiKu for advice.

Copy link
Contributor

@lng2020 lng2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those are my personal opinions. You should better discuss this with someone with a merge permission.

tools-v2/pkg/config/bs.go Show resolved Hide resolved
@setcy setcy marked this pull request as draft August 25, 2023 07:28
@setcy setcy marked this pull request as ready for review August 25, 2023 12:44
@setcy
Copy link
Contributor Author

setcy commented Sep 3, 2023

cicheck

@Cyber-SiKu
Copy link
Contributor

Please add the usage of the command in the readme

@caoxianfei1 caoxianfei1 merged commit 7840247 into opencurve:master Sep 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants