-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]tools-v2:curve bs delete volume snapshot #2637
Conversation
cicheck |
fix dco error. |
2da7e17
to
30fa137
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command is best as follows, otherwise it will be confused with copyset
curve bs delete volume snapshot
@lng2020 continue? |
30fa137
to
a7f9a88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curve/tools/snaptool/curltool.py
Lines 57 to 69 in b1eb512
def delete_or_cancel_snapshot(method, uuid, user, file): | |
params = None | |
if user and uuid: | |
params = {'Action':method, 'Version':'0.0.6', 'User':user, 'UUID':uuid, 'File':file} | |
if params is None: | |
return -1 | |
jsonobj = query(params) | |
if jsonobj['Code'] != '0': | |
print('%s uuid=%s, user=%s failed, ecode=%s, etext=%s' % (method, uuid, user, jsonobj['Code'], errcodelist[jsonobj['Code']])) | |
return -1 | |
print('%s uuid=%s, user=%s success' % (method, uuid, user)) | |
return 0 |
What want to achieve is this
@@ -0,0 +1,166 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add license
You can refer to this pr |
@lng2020 rebase and fix the conflicts. |
Signed-off-by: lng2020 <[email protected]>
a7f9a88
to
9e3fefb
Compare
There seems to be no modification? |
some conflict to fix. |
another has complete it by taking part in activitiy. |
I will close it. If you have some suggession, can reopen it again. |
What problem does this PR solve?
Issue Number: #2578
Problem Summary: add
curve bs delete volume snapshot
commandWhat is changed and how it works?
What's Changed: ./pkg/cli/command/curvebs/delete/snapshot, ./pkg/cli/command/curvebs/delete/delete.go and ./pkg/config/bs.go
How it Works: Use the filename (
path
flag) and sequence number to send adeleteSnapShotRequest
RPC to remove a snapshotSide effects(Breaking backward compatibility? Performance regression?):
Check List