Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Stops local sys admin from creating national level staff #8112

Open
wants to merge 10 commits into
base: release-v1.6.1
Choose a base branch
from
Open

fix: Stops local sys admin from creating national level staff #8112

wants to merge 10 commits into from
+160 −12

Conversation

Siyasanga
Copy link
Collaborator

Stop sys admins from de-activating themselves and stop local sys admins. from creating national level users

Also stops sys admins from being able to delete themselves in the UI:

Screenshot 2024-11-15 at 08 56 27

A National Sys Admin will see the correct roles available to them:

Screenshot 2024-11-15 at 08 45 49 Screenshot 2024-11-15 at 08 45 26

A local system admin will not see national level roles available to them:
Screenshot 2024-11-15 at 08 44 58

Screenshot 2024-11-15 at 08 44 32

@Siyasanga
Move access mgnt into the gateway service
a9c6fa8 
It is better to have in the gateway since most of access mgnt is handled there already

#7698
@Siyasanga
refactor: the getSystemRoles() to propery use filters
fb400bd 
The way we were building the criteria object was buggy especially for when we are filtering based on user roles

#7698
@Siyasanga
Filter User roles based on user that's requesting
b46c67e 
This is avoid users with lower roles creating or updating other users with higher roles

#7698
@Siyasanga Siyasanga self-assigned this Nov 29, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@Siyasanga Siyasanga added 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it 💅 Waiting For Review 🏥 Failing Tests labels Nov 29, 2024
@Siyasanga
Record changes in the CHANGELOG
101ceee 
#7698
@Siyasanga
Revert "Filter User roles based on user that's requesting"
f18c376 
This reverts commit b46c67e.
@Siyasanga
Revert "refactor: the getSystemRoles() to propery use filters"
bef4a9f 
This reverts commit fb400bd.
@Siyasanga
Revert "Move access mgnt into the gateway service"
5b9acee 
This reverts commit a9c6fa8.
@Siyasanga
Fix failing Role feature's resolver tests
274fcb6 
#7698
@Siyasanga
Stop sys admins from de-activating themselves
00d19a6 
The sys admin will no longer see the feature for their own accounts, it will only available on other users, this should stop them from eccidentally deactivating their accounts.

#7691
@Siyasanga Siyasanga linked an issue Dec 2, 2024 that may be closed by this pull request
Local system admin should not be able to create National System admin and National registrar #7698
Open
@Siyasanga Siyasanga mentioned this pull request Dec 2, 2024
Closed
@Siyasanga Siyasanga added this to the v1.6.1 milestone Dec 2, 2024
@euanmillar euanmillar added 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it ✋ On Hold and removed 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it labels Dec 2, 2024
This was referenced Dec 2, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikukissa rikukissa Awaiting requested review from rikukissa

@Zangetsu101 Zangetsu101 Awaiting requested review from Zangetsu101

At least 1 approving review is required to merge this pull request.

Assignees

@Siyasanga Siyasanga

Labels
✋ On Hold 💅 Waiting For Review
Projects
OpenCRVS Core
Status: No status
Milestone
v1.6.1
Development

Successfully merging this pull request may close these issues.

Local system admin should not be able to create National System admin and National registrar
2 participants
@Siyasanga @euanmillar