Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stops local sys admin from creating national level staff #8112

Merged
merged 10 commits into from
Dec 5, 2024
Merged

fix: Stops local sys admin from creating national level staff #8112

merged 10 commits into from
Dec 5, 2024

Commits on Nov 29, 2024

  1. Move access mgnt into the gateway service 

    It is better to have in the gateway since most of access mgnt is handled there already

#7698
    @Siyasanga
    Siyasanga committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    a9c6fa8 View commit details
    Browse the repository at this point in the history

  2. refactor: the getSystemRoles() to propery use filters 

    The way we were building the criteria object was buggy especially for when we are filtering based on user roles

#7698
    @Siyasanga
    Siyasanga committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    fb400bd View commit details
    Browse the repository at this point in the history

  3. Filter User roles based on user that's requesting 

    This is avoid users with lower roles creating or updating other users with higher roles

#7698
    @Siyasanga
    Siyasanga committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    b46c67e View commit details
    Browse the repository at this point in the history

  4. Record changes in the CHANGELOG 

    #7698
    @Siyasanga
    Siyasanga committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    101ceee View commit details
    Browse the repository at this point in the history

  5. Revert "Filter User roles based on user that's requesting" 

    This reverts commit b46c67e.
    @Siyasanga
    Siyasanga committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    f18c376 View commit details
    Browse the repository at this point in the history

  6. Revert "refactor: the getSystemRoles() to propery use filters" 

    This reverts commit fb400bd.
    @Siyasanga
    Siyasanga committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    bef4a9f View commit details
    Browse the repository at this point in the history

  7. Revert "Move access mgnt into the gateway service" 

    This reverts commit a9c6fa8.
    @Siyasanga
    Siyasanga committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    5b9acee View commit details
    Browse the repository at this point in the history

  8. Fix failing Role feature's resolver tests 

    #7698
    @Siyasanga
    Siyasanga committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    274fcb6 View commit details
    Browse the repository at this point in the history

  9. Stop sys admins from de-activating themselves 

    The sys admin will no longer see the feature for their own accounts, it will only available on other users, this should stop them from eccidentally deactivating their accounts.

#7691
    @Siyasanga
    Siyasanga committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    00d19a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Minor tisy up

    @euanmillar
    euanmillar committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    64e57ee View commit details
    Browse the repository at this point in the history