Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Fix indents for process.apparmorProfile and .selinuxLabel #330

Merged
merged 1 commit into from
Mar 3, 2016

Conversation

wking
Copy link
Contributor

@wking wking commented Mar 2, 2016

These slipped through in 5a8a779 (Move process specific settings to
process, 2016-03-02, #329).

These slipped through in 5a8a779 (Move process specific settings to
process, 2016-03-02, opencontainers#329).

Signed-off-by: W. Trevor King <[email protected]>
@vishh
Copy link
Contributor

vishh commented Mar 2, 2016

How did you identify this? Is it possible to detect such errors as part of precommit?

@wking
Copy link
Contributor Author

wking commented Mar 2, 2016

On Wed, Mar 02, 2016 at 02:35:46PM -0800, Vish Kannan wrote:

How did you identify this?

I read through 1 ;).

I si tpossible to detect such errors as part of precommit?

I think an easier way to detect these errors is to wait more than an
hour before merging a PR ;).

@crosbymichael
Copy link
Member

LGTM

crosbymichael added a commit that referenced this pull request Mar 3, 2016
config: Fix indents for process.apparmorProfile and .selinuxLabel
@crosbymichael crosbymichael merged commit a1e32a8 into opencontainers:master Mar 3, 2016
@wking wking deleted the process-security-indent branch March 3, 2016 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants