Move process specific settings to process #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves process specific settings like caps, apparmor, and selinux process label onto the process structure to allow the same settings to be changed at exec time. Signed-off-by: Michael Crosby <[email protected]>
|
LGTM |
1 similar comment
|
LGTM |
vbatts
added a commit
that referenced
this pull request
Mar 2, 2016
Move process specific settings to process
| // ApparmorProfile specified the apparmor profile for the container. | ||
| ApparmorProfile string `json:"apparmorProfile"` | ||
| // SelinuxProcessLabel specifies the selinux context that the container process is run as. | ||
| SelinuxProcessLabel string `json:"selinuxProcessLabel"` | ||
| // Seccomp specifies the seccomp security settings for the container. | ||
| Seccomp Seccomp `json:"seccomp"` |
There was a problem hiding this comment.
Shouldn't we move seccomp as well?
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Mar 2, 2016
These slipped through in 5a8a779 (Move process specific settings to process, 2016-03-02, opencontainers#329). Signed-off-by: W. Trevor King <[email protected]>
vbatts
added a commit
to vbatts/oci-runtime-spec
that referenced
this pull request
Mar 3, 2016
Signed-off-by: Vincent Batts <[email protected]>
vbatts
added a commit
to vbatts/oci-runtime-spec
that referenced
this pull request
Mar 9, 2016
Signed-off-by: Vincent Batts <[email protected]>
vbatts
added a commit
to vbatts/oci-runtime-spec
that referenced
this pull request
Mar 9, 2016
Signed-off-by: Vincent Batts <[email protected]>
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Mar 9, 2016
The label changed in 5a8a779 (Move process specific settings to process, 2016-03-02, opencontainers#329) and 7bf06d5 (source and schema: differentiate with examples, 2015-12-18, opencontainers#276) missed this instance when rebasing around opencontainers#329. Signed-off-by: W. Trevor King <[email protected]>
Mashimiao
pushed a commit
to Mashimiao/specs
that referenced
this pull request
Aug 19, 2016
These slipped through in 5a8a779 (Move process specific settings to process, 2016-03-02, opencontainers#329). Signed-off-by: W. Trevor King <[email protected]>
Mashimiao
pushed a commit
to Mashimiao/specs
that referenced
this pull request
Aug 19, 2016
The label changed in 5a8a779 (Move process specific settings to process, 2016-03-02, opencontainers#329) and 7bf06d5 (source and schema: differentiate with examples, 2015-12-18, opencontainers#276) missed this instance when rebasing around opencontainers#329. Signed-off-by: W. Trevor King <[email protected]>
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
May 10, 2017
Since f9dc90b (make link usage consistent across the specification, 2017-02-09, opencontainers#687), the official style is to only use reference-style links for external links. I expect the remaining three entries just slipped through. This commit adjusts everything found with: $ git grep ']: [a-z]' | grep -v http It also fixes the underscore -> hyphen in the glossary.md#container-namespace target and updates the capabilities location to catch up with 5a8a779 (Move process specific settings to process, 2016-03-02, opencontainers#329). Signed-off-by: W. Trevor King <[email protected]>
This was referenced May 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves process specific settings like caps, apparmor, and selinux
process label onto the process structure to allow the same settings to
be changed at exec time.
Signed-off-by: Michael Crosby [email protected]