Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgroup2: capitalize io stats read and write Op values #2965

Merged
merged 1 commit into from
May 28, 2021
Merged

cgroup2: capitalize io stats read and write Op values #2965

merged 1 commit into from
May 28, 2021

Conversation

iyashu
Copy link
Contributor

@iyashu iyashu commented May 26, 2021

Fixes #2964

@AkihiroSuda AkihiroSuda added this to the 1.0.0 milestone May 27, 2021
@AkihiroSuda AkihiroSuda added area/cgroupv2 area/go-api libcontainer Go API labels May 27, 2021
@dims
Copy link
Contributor

dims commented May 27, 2021

yes please! LGTM

cyphar
cyphar approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably add some kind of test to make sure we don't have divergences like this in the future.

@cyphar cyphar closed this in a2d86b7 May 28, 2021
@cyphar cyphar merged commit a2d86b7 into opencontainers:master May 28, 2021
@dims dims mentioned this pull request Jun 1, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@cyphar cyphar cyphar approved these changes

@dims dims dims approved these changes

Assignees
No one assigned
Labels
area/cgroupv2 area/go-api libcontainer Go API
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Inconsistent IO stats Op values between cgroup v1 and v2
4 participants
@iyashu @dims @cyphar @AkihiroSuda