VERSION: release runc 1.0.0 #2971

cyphar · 2021-06-01T09:11:52Z

This PR needs 5 votes to pass:

Michael Crosby [email protected] (@crosbymichael)
Mrunal Patel [email protected] (@mrunalp)
Daniel, Dao Quang Minh [email protected] (@dqminh)
Qiang Huang [email protected] (@hqhq)
Aleksa Sarai [email protected] (@cyphar)
Akihiro Suda [email protected] (@AkihiroSuda)
Kir Kolyshkin [email protected] (@kolyshkin)

v1.0.0 -- "A wizard is never late, nor is he early, he arrives precisely when he means to."

This release fixes a few bugs found (almost all related to cgroupv2
handling), and is the first non-rc release of runc in 5 years
(v1.0.0-rc1 was released in 2016). It's been a very long road, and we
thank the many contributors and maintainers that helped us get to this
point (approximately 422 people in total).

As runc follows Semantic Versioning, we will endeavor to not make any
breaking changes without bumping the major version number of runc.

However, it should be noted that Go API usage of runc's internal
implementation (libcontainer) is *not* covered by this policy -- for
historical reasons, this code was not moved into an "internal" package
(this feature did not exist in Go at the time) and because certain
projects currently depend on this, we have not yet moved this code into
an internal package. Despite this, we reserve the right to make breaking
changes in our Go APIs (though we will note such changes in our
changelog, and will try to avoid needless disruption if possible).

Breaking changes:

 * Removed libcontainer/configs.Device* identifiers (deprecated since rc94,
   use libcontainer/devices) (#2999)
 * Removed libcontainer/system.RunningInUserNS function (deprecated since
   rc94, use libcontainer/userns) (#2999)

Deprecations:

 * The usage of relative paths for mountpoints will now produce a warning
   (such configurations are outside of the spec, and in future runc will
   produce an error when given such configurations). (#2917, #3004)

Bugfixes:

 * cgroupv2: devices: rework the filter generation to produce consistent
   results with cgroupv1, and always clobber any existing eBPF
   program(s) to fix `runc update` and avoid leaking eBPF programs
   (resulting in errors when managing containers).  (#2951)
 * cgroupv2: correctly convert "number of IOs" statistics in a
   cgroupv1-compatible way. (#2965, #2967, #2968, #2964)
 * cgroupv2: support larger than 32-bit IO statistics on 32-bit architectures.
 * cgroupv2: wait for freeze to finish before returning from the freezing
   code, optimize the method for checking whether a cgroup is frozen. (#2955)
 * cgroups/systemd: fixed "retry on dbus disconnect" logic introduced in rc94
 * cgroups/systemd: fixed returning "unit already exists" error from a systemd
   cgroup manager (regression in rc94) (#2997, #2996)

Improvements:

 * cgroupv2: support SkipDevices with systemd driver (#2958, #3019)
 * cgroup/systemd: return, not ignore, stop unit error from Destroy (#2946)
 * Fix all golangci-lint failures. (#2781, #2962)
 * Make "runc --version" output sane even when built with `go get` or
   otherwise outside of our build scripts. (#2962)
 * cgroups: set SkipDevices during runc update (so we don't modify
   cgroups at all during `runc update`). (#2994)
 * cgroup1: blkio: support BFQ weights. (#3010)
 * cgroupv2: set per-device io weights if BFQ IO scheduler is available.
   (#3022)

Thanks to the following people who made this release possible:

 * Adrian Reber <[email protected]>
 * Akihiro Suda <[email protected]>
 * Aleksa Sarai <[email protected]>
 * Antti Kervinen <[email protected]>
 * Daniel, Dao Quang Minh <[email protected]>
 * Enrico Weigelt <[email protected]>
 * Kir Kolyshkin <[email protected]>
 * Michael Crosby <[email protected]>
 * Mrunal Patel <[email protected]>
 * Peter Hunt <[email protected]>
 * Qiang Huang <[email protected]>
 * Sebastiaan van Stijn <[email protected]>
 * Shiming Zhang <[email protected]>
 * Yashpal Choudhary <[email protected]>

Signed-off-by: Aleksa Sarai <[email protected]>

Signed-off-by: Aleksa Sarai [email protected]

AkihiroSuda · 2021-06-01T09:20:29Z

Triggering CIs
moby/moby#42450 containerd/containerd#5552 containerd/nerdctl#231 moby/buildkit#2143

AkihiroSuda · 2021-06-01T09:33:48Z

Can we have an official announcement on https://opencontainers.org/posts/announcements/ ? 🎉

VERSION

h-vetinari · 2021-06-01T09:55:05Z

Can we have an official announcement on https://opencontainers.org/posts/announcements/ ? 🎉

I think that would be a great idea, and deserve a longer victory lap than the proposed release notes in the OP. There's a lot of history contained across:

7+ years since 6415e8b
2 repo changes (incl. founding opencontainers?)
95 15 release candidates over 5 years
various CVEs
the hook drama
cgroups v2, rootless, etc. etc.

and concluding this epic journey would IMO really deserve some celebratory commemoration.

cyphar · 2021-06-01T09:57:02Z

Yeah I expect we're going to have a proper celebration of some kind.

95 15 release candidates

Please stop rubbing it in. 😅 😅 😅

I promise I've actually read the SemVer spec now.

AkihiroSuda

Moby CI is failing 😭

moby/moby#42450 (comment)

=== RUN TestBuildMultiStageCopy/copy_to_newdir
--- FAIL: TestBuildMultiStageCopy/copy_to_newdir (0.42s)
build_test.go:182: {"stream":"Step 1/8 : FROM busybox AS base"}
{"stream":"\n"}
{"stream":" ---\u003e 1c35c4412082\n"}
{"stream":"Step 2/8 : RUN mkdir existingdir"}
{"stream":"\n"}
{"stream":" ---\u003e Running in a65f6cb4628e\n"}
{"stream":"Removing intermediate container a65f6cb4628e\n"}
{"errorDetail":{"message":"failed to create shim: OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: process_linux.go:508: setting cgroup config for procHooks process caused: failed to call BPF_PROG_ATTACH (BPF_CGROUP_DEVICE, BPF_F_ALLOW_MULTI): can't attach program: invalid argument: unknown"},"error":"failed to create shim: OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: process_linux.go:508: setting cgroup config for procHooks process caused: failed to call BPF_PROG_ATTACH (BPF_CGROUP_DEVICE, BPF_F_ALLOW_MULTI): can't attach program: invalid argument: unknown"}

cyphar · 2021-06-17T08:12:19Z

@opencontainers/runc-maintainers I've rebased this on top of the all the necessary fixes we've merged in the past few weeks, so we need to re-do the vote.

Moby CI passes now.

hqhq · 2021-06-17T08:50:05Z

LGTM

cyphar · 2021-06-17T14:26:27Z

LGTM.

AkihiroSuda

LGTM

kolyshkin

LGTM

mrunalp · 2021-06-18T21:00:08Z

LGTM

thaJeztah

LGTM (nb)

cyphar · 2021-06-19T07:15:07Z

That's 5. I'll do the release on Monday.

tao12345666333

LGTM (nb)

kolyshkin · 2021-06-21T18:18:07Z

I took a liberty to remove

cgroupv2: various SetFreezer optimisations. (libct/cg/fs2/freezer: optimize and fix #2955)

line from the release notes, as it's already described above (i.e. a duplicate).

h-vetinari · 2021-07-01T19:21:29Z

This could still use an announcement on https://opencontainers.org/, the mailing list, etc... Not sure that's worth an issue, but can open one of course.

cyphar · 2021-07-02T05:20:24Z

While the opencontainers website is deployed from https://github.com/opencontainers/opencontainers.org, I'll ping @caniszczyk since usually someone else drafts the blog announcements.

cyphar added this to the 1.0.0 milestone Jun 1, 2021

dqminh previously approved these changes Jun 1, 2021

View reviewed changes

This was referenced Jun 1, 2021

update runc binary to v1.0.0 GA moby/moby#42450

Merged

update runc binary & library to v1.0.0 GA containerd/containerd#5552

Merged

update runc binary to v1.0.0 GA containerd/nerdctl#231

Merged

update runc binary to v1.0.0 GA moby/buildkit#2143

Merged

cyphar requested review from AkihiroSuda, crosbymichael, dqminh, hqhq, kolyshkin and mrunalp June 1, 2021 09:52

vrothberg reviewed Jun 1, 2021

View reviewed changes

VERSION Show resolved Hide resolved

cyphar removed the request for review from dqminh June 1, 2021 09:53

This comment has been minimized.

Sign in to view

AkihiroSuda previously requested changes Jun 1, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

crosbymichael previously approved these changes Jun 1, 2021

View reviewed changes

cyphar marked this pull request as draft June 1, 2021 15:49

This comment has been minimized.

Sign in to view

mrunalp previously approved these changes Jun 1, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

cyphar dismissed stale reviews from Hotdogszbg, kolyshkin, mrunalp, crosbymichael, and dqminh via 041caf1 June 17, 2021 08:11

cyphar marked this pull request as ready for review June 17, 2021 08:17

cyphar requested review from kolyshkin, crosbymichael, AkihiroSuda, mrunalp and dqminh June 17, 2021 08:17

hqhq approved these changes Jun 17, 2021

View reviewed changes

AkihiroSuda approved these changes Jun 18, 2021

View reviewed changes

AkihiroSuda removed the status/needs-rebase label Jun 18, 2021

kolyshkin approved these changes Jun 18, 2021

View reviewed changes

mrunalp approved these changes Jun 18, 2021

View reviewed changes

thaJeztah approved these changes Jun 18, 2021

View reviewed changes

tao12345666333 approved these changes Jun 19, 2021

View reviewed changes

cyphar closed this in 2fc269d Jun 22, 2021

cyphar merged commit 2fc269d into opencontainers:master Jun 22, 2021

cyphar deleted the release-1.0 branch July 2, 2021 13:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VERSION: release runc 1.0.0 #2971

VERSION: release runc 1.0.0 #2971

cyphar commented Jun 1, 2021 •

edited by kolyshkin

Loading

AkihiroSuda commented Jun 1, 2021

AkihiroSuda commented Jun 1, 2021

h-vetinari commented Jun 1, 2021 •

edited

Loading

cyphar commented Jun 1, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AkihiroSuda left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cyphar commented Jun 17, 2021

hqhq commented Jun 17, 2021

cyphar commented Jun 17, 2021

AkihiroSuda left a comment

kolyshkin left a comment

mrunalp commented Jun 18, 2021

thaJeztah left a comment

cyphar commented Jun 19, 2021

tao12345666333 left a comment

kolyshkin commented Jun 21, 2021

h-vetinari commented Jul 1, 2021

cyphar commented Jul 2, 2021

VERSION: release runc 1.0.0 #2971

VERSION: release runc 1.0.0 #2971

Conversation

cyphar commented Jun 1, 2021 • edited by kolyshkin Loading

AkihiroSuda commented Jun 1, 2021

AkihiroSuda commented Jun 1, 2021

h-vetinari commented Jun 1, 2021 • edited Loading

cyphar commented Jun 1, 2021 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AkihiroSuda left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cyphar commented Jun 17, 2021

hqhq commented Jun 17, 2021

cyphar commented Jun 17, 2021

AkihiroSuda left a comment

Choose a reason for hiding this comment

kolyshkin left a comment

Choose a reason for hiding this comment

mrunalp commented Jun 18, 2021

thaJeztah left a comment

Choose a reason for hiding this comment

cyphar commented Jun 19, 2021

tao12345666333 left a comment

Choose a reason for hiding this comment

kolyshkin commented Jun 21, 2021

h-vetinari commented Jul 1, 2021

cyphar commented Jul 2, 2021

cyphar commented Jun 1, 2021 •

edited by kolyshkin

Loading

h-vetinari commented Jun 1, 2021 •

edited

Loading

cyphar commented Jun 1, 2021 •

edited

Loading