Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recttty: nits #2694

Merged
merged 3 commits into from
Dec 2, 2020
Merged

recttty: nits #2694

merged 3 commits into from
Dec 2, 2020

Commits on Dec 1, 2020

  1. recvtty: use ioutil.Discard 

    Saves us a few lines of code.

Signed-off-by: Kir Kolyshkin <[email protected]>
    @kolyshkin
    kolyshkin committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    4bbfd2e View commit details
    Browse the repository at this point in the history

  2. recvtty: fix waiting for both goroutines 

    It looks like we need to wait for the both copy goroutines to finish,
not just the one that happen to finish first.

Signed-off-by: Kir Kolyshkin <[email protected]>
    @kolyshkin
    kolyshkin committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    6b41b46 View commit details
    Browse the repository at this point in the history

  3. recvtty: fix errcheck linter warnings 

    Fixes the following errcheck linter warnings

> contrib/cmd/recvtty/recvtty.go:115:10: Error return value of `io.Copy` is not checked (errcheck)
> 		io.Copy(os.Stdout, c)
> 		       ^
> contrib/cmd/recvtty/recvtty.go:120:11: Error return value of `io.Copy` is not checked (errcheck)
> 			io.Copy(c, os.Stdin)
> 			       ^
> contrib/cmd/recvtty/recvtty.go:175:11: Error return value of `io.Copy` is not checked (errcheck)
>			io.Copy(devnull, master)
>			       ^

Signed-off-by: Kir Kolyshkin <[email protected]>
    @kolyshkin
    kolyshkin committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    de80aae View commit details
    Browse the repository at this point in the history